Skip to content

feat: move sources under the main text#30035

Merged
joaosantos15 merged 2 commits into
mainfrom
TSA-515-whats-happening-sources
May 13, 2026
Merged

feat: move sources under the main text#30035
joaosantos15 merged 2 commits into
mainfrom
TSA-515-whats-happening-sources

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented May 12, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

In What's Happening the sources will now be displayed right under the main text, instead of being sticky at the bottom.
image

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/layout change limited to the expanded card; main risk is minor regressions in press target/spacing or date rendering in the new inline sources row.

Overview
UI change: The expanded What’s Happening card now renders the sources row inline under the description (within the scroll area) instead of as a fixed/sticky footer, while keeping the same onSourcesPress behavior.

Adds a memoized formattedDate for the inline row and updates the unit test to mock formatRelativeTime and assert the relative date text is shown when sources are present.

Reviewed by Cursor Bugbot for commit 3249a52. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 12, 2026
@joaosantos15 joaosantos15 enabled auto-merge May 12, 2026 11:04
@zone-live zone-live added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 12, 2026
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to two files in the WhatsHappeningDetailView component:

  1. WhatsHappeningExpandedCard.tsx: A UI layout refactoring that moves the "sources" section from a fixed footer at the bottom of the card to inline within the description area (next to the description text). It also memoizes the formattedDate value. This is a purely cosmetic/structural change with no functional impact on core wallet flows.

  2. WhatsHappeningExpandedCard.test.tsx: Unit test updates to match the renamed test description and the new formatRelativeTime mock.

Why no E2E tags are needed:

  • No E2E tests exist for the WhatsHappening/WhatsHappeningDetailView feature (confirmed via grep)
  • The change is a UI layout refactoring (sources moved from footer to inline), not a functional change
  • No changes to navigation, controllers, Engine, or any shared infrastructure
  • No changes to critical paths (confirmations, accounts, swaps, etc.)
  • The WhatsHappening feature is part of the Homepage/Trending section, but SmokeWalletPlatform E2E tests don't cover this specific component
  • The change is fully covered by the updated unit tests

Performance Test Selection:
The changes are purely UI layout refactoring within a single card component. No performance-sensitive operations are affected - no list rendering changes, no new data fetching, no state management changes, no animation changes. The memoization of formattedDate is a minor optimization, not a performance concern.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 12, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@joaosantos15 joaosantos15 added this pull request to the merge queue May 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 12, 2026
@joaosantos15 joaosantos15 added this pull request to the merge queue May 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 12, 2026
@joaosantos15 joaosantos15 added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit de98c47 May 13, 2026
61 of 62 checks passed
@joaosantos15 joaosantos15 deleted the TSA-515-whats-happening-sources branch May 13, 2026 13:38
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zone-live zone-live zone-live approved these changes

@xavier-brochard xavier-brochard xavier-brochard approved these changes

Assignees

No one assigned

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaosantos15 @zone-live @xavier-brochard