Skip to content

feat: adds a deeplink to whats happening#30030

Merged
joaosantos15 merged 7 commits into
mainfrom
TSA-511-deeplink-whats-happening
May 13, 2026
Merged

feat: adds a deeplink to whats happening#30030
joaosantos15 merged 7 commits into
mainfrom
TSA-511-deeplink-whats-happening

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented May 12, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a deep-link to the new What's Happening page which always open the first card of the section.

whats-happening-deeplink.mp4

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new supported deep link action and routes it through the legacy universal-link handler into in-app navigation, which could affect deep link routing/analytics if misconfigured.

Overview
Adds support for a new whats-happening deep link that navigates directly to Routes.WHATS_HAPPENING_DETAIL and marks the traffic source as WhatsHappeningSource.Deeplink.

This wires the new action through deeplink constants/types, the legacy handleUniversalLink switch/whitelist, and deep link analytics route mapping/extraction, with new unit tests for the handler and universal-link behavior. It also relaxes WhatsHappeningDetailView params so initialIndex is optional (defaulting to 0) and updates navigation typing/tests accordingly.

Reviewed by Cursor Bugbot for commit 66792cc. Bugbot is set up for automated code reviews on this repo. Configure here.

@joaosantos15 joaosantos15 requested a review from a team as a code owner May 12, 2026 09:24
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 12, 2026
cursor[bot]
cursor Bot reviewed May 12, 2026
View reviewed changes
Comment thread app/core/DeeplinkManager/handlers/legacy/handleWhatsHappeningUrl.ts Outdated
cursor[bot]
cursor Bot reviewed May 12, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 088dc98. Configure here.

Comment thread app/components/Views/WhatsHappeningDetailView/WhatsHappeningDetailView.tsx Outdated
zone-live
zone-live approved these changes May 12, 2026
View reviewed changes

@zone-live zone-live left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaosantos15 joaosantos15 enabled auto-merge May 12, 2026 10:33
@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeSwap
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 78%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new deeplink handler for 'whats-happening' URLs that navigates to the WhatsHappeningDetailView, which is part of the Trending/WalletPlatform feature area. Key changes:

  1. New deeplink action (WHATS_HAPPENING = 'whats-happening') added to the ACTIONS enum, PREFIXES, SUPPORTED_ACTIONS list, and whitelisted actions in handleUniversalLink.ts
  2. New handler handleWhatsHappeningUrl.ts navigates to Routes.WHATS_HAPPENING_DETAIL with WhatsHappeningSource.Deeplink
  3. Navigation params type change - WhatsHappeningDetailView params updated: removed items: WhatsHappeningItem[], made initialIndex optional, added source: WhatsHappeningSourceValue
  4. Analytics - New DeepLinkRoute.WHATS_HAPPENING added to analytics tracking
  5. WhatsHappeningDetailView.tsx - Made initialIndex optional with a default constant

SmokeWalletPlatform: Selected because WhatsHappening is a section within the Trending tab, which is directly covered by SmokeWalletPlatform. The navigation params type change to WhatsHappeningDetailView could affect existing callers navigating to this view from the Homepage/Trending sections.

SmokeSwap: Selected because it contains deeplink smoke tests (swap-deeplink-smoke.spec.ts) that exercise the same deeplink infrastructure (handleUniversalLink.ts). The changes to SUPPORTED_ACTIONS, WHITELISTED_ACTIONS, and the deeplink routing logic in handleUniversalLink.ts could potentially affect existing deeplink handling for swap flows.

No existing E2E tests specifically cover WhatsHappening deeplinks, so these tags provide the best coverage for regression testing the affected areas. Performance tests are not warranted as these are additive navigation/routing changes with no performance-sensitive code paths.

Performance Test Selection:
The changes are purely additive navigation/routing changes - adding a new deeplink action and handler. There are no changes to rendering performance, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joaosantos15 joaosantos15 added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 38851f3 May 13, 2026
114 of 116 checks passed
@joaosantos15 joaosantos15 deleted the TSA-511-deeplink-whats-happening branch May 13, 2026 09:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@zone-live zone-live zone-live approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-M team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaosantos15 @zone-live @tommasini