fix: fix trending label display cp-7.77.0#30020
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: The
However, the actual code change only affects the default prop behavior when SmokeWalletPlatform is sufficient to validate the Trending FilterBar behavior. No performance tests are needed for this minor UI prop default fix. Performance Test Selection: |
|
The committed fixture schema is out of date. To update, comment: |



Description
On small screen devices (e.g., iPhone SE), the
FilterButtonlabel text (e.g., "Price change") wraps to two lines. The root cause: callers like the price-change button and Bridge filter buttons don't passnumberOfLinesorellipsizeMode, so these default toundefined— allowing unlimited text wrapping whenflex-shrinkcompresses the button.This adds sensible defaults (
numberOfLines ?? 1,ellipsizeMode ?? 'tail') insideFilterButtonso all labels stay on a single line and truncate with ellipsis when constrained.Changelog
CHANGELOG entry: Fixed trending filter button labels wrapping to two lines on small screens by defaulting to single-line truncation.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change that adjusts text rendering defaults; main risk is unintended truncation in places relying on multi-line labels.
Overview
Prevents
FilterButtonlabels in Trending’sFilterBarfrom wrapping by defaultingnumberOfLinesto1andellipsizeModeto'tail'when callers don’t provide them.This standardizes truncation behavior across filter buttons on constrained layouts (e.g., small screens) without requiring each caller to pass these props.
Reviewed by Cursor Bugbot for commit 66a57c8. Bugbot is set up for automated code reviews on this repo. Configure here.