Skip to content

fix: titles on explore search cp-7.77.0#29985

Merged
juanmigdr merged 1 commit into
mainfrom
chore/update-titles
May 12, 2026
Merged

fix: titles on explore search cp-7.77.0#29985
juanmigdr merged 1 commit into
mainfrom
chore/update-titles

Conversation

@juanmigdr

@juanmigdr juanmigdr commented May 11, 2026

Copy link
Copy Markdown
Member

Description

Update these titles:

  • "Trending" -> "Crypto"
  • "Popular" -> "Sites"

In the explore search screen

Changelog

CHANGELOG entry: update titles on explore search

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3190

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI copy/i18n change limited to Explore search section headers; no business logic or data handling changes.

Overview
Updates Explore omni-search section headers to use clearer labels.

Specifically renames the tokens section title from trending.trending_tokens ("Trending") to a new trending.crypto ("Crypto") string, and changes the sites section title from sites.popular to trending.sites ("Sites").

Reviewed by Cursor Bugbot for commit 5048cf2. Bugbot is set up for automated code reviews on this repo. Configure here.

@juanmigdr juanmigdr changed the title fix: titles on explore search fix: titles on explore search cp-7.77.0 May 11, 2026
@github-actions github-actions Bot added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XS labels May 11, 2026
@juanmigdr juanmigdr removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are minimal and cosmetic:

  1. useExploreSearch.ts: Two string key substitutions for section titles in the TrendingView search results — tokens section renamed from trending.trending_tokens ("Trending") to trending.crypto ("Crypto"), and sites section renamed from sites.popular to trending.sites.
  2. en.json: Added the new trending.crypto locale string ("Crypto").

These are purely UI label changes in the TrendingView search feature. SmokeWalletPlatform directly covers the Trending discovery tab including search functionality and browsing content feeds (Tokens, Sites sections). No other subsystems are affected — no controllers, no navigation, no confirmations, no accounts, no networks. Risk is low as only display strings are changed.

Performance Test Selection:
String/label changes in the TrendingView search have no meaningful performance impact. No rendering logic, data fetching, or state management was modified.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@juanmigdr juanmigdr added this pull request to the merge queue May 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 12, 2026
@juanmigdr juanmigdr added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 2c65619 May 12, 2026
140 of 168 checks passed
@juanmigdr juanmigdr deleted the chore/update-titles branch May 12, 2026 09:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants