Skip to content

chore: cherry-pick fix(homepage): hub page discovery tabs UX & scroll improvements#29931

Merged
vpintorico merged 1 commit into
release/7.77.0from
cherry-pick-7-77-0-b1361a1
May 8, 2026
Merged

chore: cherry-pick fix(homepage): hub page discovery tabs UX & scroll improvements#29931
vpintorico merged 1 commit into
release/7.77.0from
cherry-pick-7-77-0-b1361a1

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented May 8, 2026

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

~

Before

~

After

~

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes header/tab-bar hide/show behavior and animation plumbing across Homepage Discovery Tabs, Predict, and Perps, which can regress layout/scroll interactions on iOS/Android.

Overview
Improves Hub Page Discovery Tabs UX by moving icon-collapse animation to Reanimated: TabIconAnimationContext now provides a SharedValue and TabsIconTab animates icon height/margin/opacity on the UI thread, while keeping a mirrored Animated.Value only for the dark-mode gradient fade.

Updates the discovery tab content layout (Portfolio scroll container spacing, removing extra mt-2 in TabsIconList, adding topInset support to PerpsHomeView) and forwards wallet header coordination props into PredictFeed.

Extends useFeedScrollManager so, when embedded, it hides Predict’s header and its tab bar together and animates walletHeaderTranslateY in sync; adds clamped partial-collapse support to TabsIconBar via new collapseBy prop. Tests are added/updated to cover the new props and non-crashing behavior.

Reviewed by Cursor Bugbot for commit 6a1cc4f. Bugbot is set up for automated code reviews on this repo. Configure here.

@vinnyhoward vinnyhoward requested review from a team as code owners May 8, 2026 17:37
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-ux Mobile UX team label May 8, 2026
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added the size-L label May 8, 2026
@vpintorico vpintorico enabled auto-merge (squash) May 8, 2026 17:54
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

@vpintorico vpintorico merged commit 516dc48 into release/7.77.0 May 8, 2026
121 checks passed
@vpintorico vpintorico deleted the cherry-pick-7-77-0-b1361a1 branch May 8, 2026 18:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants