chore(runway): cherry-pick feat: allow custom sorting in perps from explore cp-7.77.0#29929
Merged
Merged
Conversation
…xplore cp-7.77.0 (#29912) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Allow custom sorting in perps from explore <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: allow custom sorting in perps from explore ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3170 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/b149183e-451c-4345-8e44-e9c8b01dbb61 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk because it changes default sorting behavior and navigation params for the Perps market list, which can affect perceived ordering and persisted sort direction across screens. > > **Overview** > **Explore → Perps market list navigation now forwards a default sort option** via new `defaultSortOptionId` route param so the full market list opens with the same ordering as the Explore feed. > > `usePerpsMarketListView` accepts this override and **resets sort direction to the controller default when the override differs from the user’s saved option**, while preserving the saved direction when it matches. `usePerpsFeed` now exposes a per-variant `defaultSortOptionId` (backed by `PERPS_VARIANT_SORT_OPTION`) and keeps search ordering consistent (Fuse relevance preserved for non-macro; macro still sorts by volume). > > Explore perps sections (`NowTab`, `CryptoTab`, `MacroTab`, `RwasTab`, `PerpsToggleBlock`) were updated to pass the sort option through, and new/updated unit tests cover the override logic and navigation wiring. `useStocksFeed` was adjusted so **search results include RWAs across chains**, while the tab view remains Ethereum-only, with tests added. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ddc377c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
vpintorico
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Allow custom sorting in perps from explore
Changelog
CHANGELOG entry: allow custom sorting in perps from explore
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3170
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-05-08.at.14.09.40.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Medium risk because it changes default sorting behavior and navigation
params for the Perps market list, which can affect perceived ordering
and persisted sort direction across screens.
Overview
Explore → Perps market list navigation now forwards a default sort
option via new
defaultSortOptionIdroute param so the full marketlist opens with the same ordering as the Explore feed.
usePerpsMarketListViewaccepts this override and resets sortdirection to the controller default when the override differs from the
user’s saved option, while preserving the saved direction when it
matches.
usePerpsFeednow exposes a per-variantdefaultSortOptionId(backed by
PERPS_VARIANT_SORT_OPTION) and keeps search orderingconsistent (Fuse relevance preserved for non-macro; macro still sorts by
volume).
Explore perps sections (
NowTab,CryptoTab,MacroTab,RwasTab,PerpsToggleBlock) were updated to pass the sort option through, andnew/updated unit tests cover the override logic and navigation wiring.
useStocksFeedwas adjusted so search results include RWAs acrosschains, while the tab view remains Ethereum-only, with tests added.
Reviewed by Cursor Bugbot for commit
ddc377c. Bugbot is set up for automated
code reviews on this repo. Configure
here.