Description

Following up from feedback on the Hub Page Discovery Tabs PR: the new collapseBy prop on TabsIconBar was too vague. Renamed to collapseHeightOffset and clarified the JSDoc. No behavior change, no consumers currently use the prop.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: TabsIconBar collapseHeightOffset prop

  Scenario: existing consumers unaffected
    Given a TabsIconBar without collapseHeightOffset
    Then it collapses to height 0 (existing behavior)

  Scenario: partial collapse
    Given a TabsIconBar with collapseAnim and collapseHeightOffset={28}
    When collapseAnim animates to 1
    Then the row shrinks by 28px (not all the way to 0)

Screenshots/Recordings

~

Before

~

After

~

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.