chore(rewards): perps campaign remove margin stat#29911
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
965c9a2 to
855c01b
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Tag Selection Rationale:
No E2E tests directly test Performance Test Selection: |
|



Description
Removes the margin requirement from the Perps Trading Campaign rewards qualification UI to match the latest design. Qualification is now driven solely by notional volume (≥ $25k); the
marginDeployedfield is dropped from DTOs, cached state, controller cache read/write, locale keys, and tests. On the stats screen PnL and Volume now share one row, and the summary card replaces the margin StatCell with a spacer so Volume stays left-aligned.Changelog
CHANGELOG entry: null
Screenshots/Recordings
Note
Medium Risk
Medium risk because it removes the
marginDeployedfield from Perps leaderboard position DTO/state and updates controller caching logic, which could break consumers expecting that data or older cached shapes.Overview
Updates the Perps Trading Campaign flow to drop the margin-deployed metric and requirement, making qualification driven solely by notional volume.
This removes
marginDeployedfrom the Perps leaderboard position DTO and cached state, updatesRewardsControllercache read/write accordingly, and simplifies the stats/summary UI to no longer render a margin StatCell (using a spacer to preserve layout). Tests and locale strings are updated to match the new three-stat display and revised qualification semantics.Reviewed by Cursor Bugbot for commit 855c01b. Bugbot is set up for automated code reviews on this repo. Configure here.