Skip to content

fix: add CMAKE_VERSION override to build.yml for RN 0.81 compatibility#29899

Merged
andrepimenta merged 1 commit into
mainfrom
chore/fix-android-build
May 8, 2026
Merged

fix: add CMAKE_VERSION override to build.yml for RN 0.81 compatibility#29899
andrepimenta merged 1 commit into
mainfrom
chore/fix-android-build

Conversation

@adnxy

@adnxy adnxy commented May 8, 2026

Copy link
Copy Markdown
Contributor

Description

After the React Native 0.81.5 upgrade, the Android build step in build.yml fails with error CXX1300 because RN's ReactAndroid/build.gradle.kts defaults to CMake 3.30.5, which isn't installed on CI runners (they have 3.22.1). This adds the CMAKE_VERSION: '3.22.1' env var override

The same fix already appliedin build-android-e2e.yml, so Gradle uses the available CMake instead of failing.

Changelog

CHANGELOG entry: @metamask/mobile - Fixed: Add CMAKE_VERSION override to build.yml to fix Android CI build after RN 0.81.5 upgrade

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this only adjusts CI build environment configuration, but could affect Android native build tooling if a different CMake version is actually required on some runners.

Overview
Ensures CI builds don’t fail after the React Native 0.81 upgrade by exporting CMAKE_VERSION=3.22.1 during the main build.yml build step, overriding RN’s default request for CMake 3.30.5 that isn’t available on the runner.

Reviewed by Cursor Bugbot for commit 85aee8d. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adnxy adnxy marked this pull request as ready for review May 8, 2026 09:21
@adnxy adnxy requested a review from a team as a code owner May 8, 2026 09:21
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change in this PR is adding a single environment variable CMAKE_VERSION: '3.22.1' to the Android build job in .github/workflows/build.yml. This is a pure CI/build infrastructure fix for React Native 0.81 compatibility on self-hosted runners that only have CMake 3.22.1 installed (not the 3.30.5 requested by RN's build scripts). The change:

  1. Does not modify any application source code
  2. Does not affect any E2E test infrastructure, page objects, or test configurations
  3. Does not change any user-facing functionality or flows
  4. Is isolated to the Android build compilation step (CXX1300 error fix)
  5. Has no impact on test execution or test results

No E2E test tags are needed since this is purely a build system fix with no impact on app behavior or test infrastructure.

Performance Test Selection:
This change only adds a CMake version environment variable to the Android build job. It has no impact on app performance, rendering, data loading, or any user-facing functionality. No performance tests are needed.

View GitHub Actions results

@adnxy adnxy added the team-mobile-platform Mobile Platform team label May 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

@andrepimenta andrepimenta merged commit be3ad63 into main May 8, 2026
115 of 128 checks passed
@andrepimenta andrepimenta deleted the chore/fix-android-build branch May 8, 2026 10:34
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants