Skip to content

test: remove appwright dependencies#29877

Merged
cortisiko merged 2 commits into
mainfrom
MMQA-1657
May 7, 2026
Merged

test: remove appwright dependencies#29877
cortisiko merged 2 commits into
mainfrom
MMQA-1657

Conversation

@cortisiko

@cortisiko cortisiko commented May 7, 2026

Copy link
Copy Markdown
Member

Description

Removes the custom Yarn patching of appwright (and related form-data override) and drops appwright from dependencies/unplugged resolutions.

Deletes the Appwright-based E2E/performance test harness (tests/appwright.config.ts plus the Appwright* helpers and performance fixture exports), leaving the repo without Appwright-specific test entrypoints.

Updates yarn.lock accordingly to prune appwright and a large set of transitive packages (notably ffmpeg/sharp/webdriver* related entries) and to simplify some version ranges/dedupes.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it removes appwright and associated performance/E2E fixtures/config, which may break or change how CI or local performance test runs are invoked even though it doesn’t touch production app code.

Overview
Removes appwright from the repo by deleting the custom Yarn patch and dropping the dependency/resolution overrides in package.json.

Deletes the Appwright-based E2E/performance test entrypoints and helper/fixture modules under tests/, and updates yarn.lock to prune appwright and a large set of related transitive packages (notably webdriver/ffmpeg/sharp-related).

Reviewed by Cursor Bugbot for commit 3e24b60. Bugbot is set up for automated code reviews on this repo. Configure here.

@cortisiko cortisiko requested review from a team as code owners May 7, 2026 17:04
@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 7, 2026
@cortisiko cortisiko added skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 7, 2026
@cortisiko cortisiko enabled auto-merge May 7, 2026 17:09
@cortisiko cortisiko changed the title test: remove playwright dependencies test: remove appwright dependencies May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 7277bbb May 7, 2026
113 of 114 checks passed
@cortisiko cortisiko deleted the MMQA-1657 branch May 7, 2026 19:50
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-XL skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants