Skip to content

fix(rewards): Ondo token case inconsistency#29871

Merged
sophieqgu merged 2 commits into
mainfrom
Fix-ondo-name-inconsistency
May 7, 2026
Merged

fix(rewards): Ondo token case inconsistency#29871
sophieqgu merged 2 commits into
mainfrom
Fix-ondo-name-inconsistency

Conversation

@sophieqgu

@sophieqgu sophieqgu commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

Fix Ondo tokens case inconsistency

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - E2E Test  - 2026-05-07 at 11 01 09 Simulator Screenshot - E2E Test  - 2026-05-07 at 11 01 26 Simulator Screenshot - E2E Test  - 2026-05-07 at 11 01 31

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Low-scope UI formatting change, but the new tokenLabel calls toUpperCase() unconditionally which could throw if tokenSymbol is missing/null at runtime.

Overview
Normalizes token symbols shown in OndoActivityRow details by uppercasing tokenSymbol, fixing mixed-case display (and updates the related unit test expectation from AAPLon to AAPLON).

Reviewed by Cursor Bugbot for commit f30dc80. Bugbot is set up for automated code reviews on this repo. Configure here.

@sophieqgu sophieqgu requested a review from a team as a code owner May 7, 2026 15:06
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-rewards Rewards team label May 7, 2026
@sophieqgu sophieqgu enabled auto-merge May 7, 2026 15:07
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains only 2 changed files:

  1. OndoActivityRow.tsx: A single-line change adding .toUpperCase() to token.tokenSymbol in the tokenLabel helper function. This ensures token symbols (e.g., "AAPLon" → "AAPLON") are always displayed in uppercase in the Ondo campaign activity row UI.

  2. OndoActivityRow.test.tsx: The corresponding unit test update to expect the uppercase output 'AAPLON' instead of 'AAPLon'.

Why no E2E tags are needed:

  • The change is a pure UI text formatting fix (.toUpperCase()) with no logic changes, no state management impact, no navigation changes, and no shared component modifications.
  • The Rewards/Campaigns feature has no existing E2E test coverage (confirmed via grep - no matches in e2e directory).
  • The component is only imported by OndoCampaignPortfolioView.tsx and its own test file - it's not a shared/critical component.
  • No core wallet flows (confirmations, swaps, accounts, networks, browser, snaps) are affected.
  • The change is fully validated by the updated unit test.

Performance Test Selection:
This is a trivial text formatting change (adding .toUpperCase() to a token symbol string). It has no impact on rendering performance, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@sophieqgu sophieqgu added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit a515319 May 7, 2026
76 of 80 checks passed
@sophieqgu sophieqgu deleted the Fix-ondo-name-inconsistency branch May 7, 2026 15:49
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants