Skip to content

test: add submit swap flag#29869

Merged
pnarayanaswamy merged 2 commits into
mainfrom
submit-trx-flag
May 7, 2026
Merged

test: add submit swap flag#29869
pnarayanaswamy merged 2 commits into
mainfrom
submit-trx-flag

Conversation

@pnarayanaswamy

@pnarayanaswamy pnarayanaswamy commented May 7, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk because changes are limited to performance test specs, but enabling SUBMIT_SWAP will execute real swap confirmations and activity assertions, which may increase test flakiness and runtime.

Overview
Adds an optional “submit swap” path to the performance swap login specs so they can go beyond quote timing and actually confirm the swap when SUBMIT_SWAP=true.

When enabled, the tests dismiss the keypad, tap Confirm swap, and validate the resulting activity via checkSwapActivity for both the ETH→USDC and cross-chain ETH→SOL flows.

Reviewed by Cursor Bugbot for commit 60810d3. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 7, 2026
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 7, 2026
@pnarayanaswamy pnarayanaswamy added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 7, 2026
@github-actions github-actions Bot added the size-S label May 7, 2026
@pnarayanaswamy pnarayanaswamy enabled auto-merge May 7, 2026 14:38
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: @PerformanceSwaps
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are exclusively in the tests/performance/login/ directory — they are performance test spec files, not app source code. The changes add an optional swap submission flow (guarded by process.env.SUBMIT_SWAP === 'true') to two existing performance test scenarios: cross-chain-swap-flow (ETH→SOL) and eth-swap-flow (ETH→USDC). The addition imports checkSwapActivity from an existing helper already used in smoke and regression tests. No app source code, controllers, UI components, or E2E Detox test infrastructure was modified. Per the guidance: "Changes to wdio/ or tests/performance directories (separate test frameworks) do not require Detox tags - select none unless app code is also changed." No app code was changed, so no Detox E2E tags are needed.

Performance Test Selection:
Both changed files are performance test specs tagged with PerformanceSwaps (and PerformanceLogin). The changes extend these tests with an optional swap submission and activity verification step (behind SUBMIT_SWAP env var). Since the changes are directly to performance test infrastructure for swap flows, running @PerformanceSwaps is appropriate to validate the new test logic works correctly. @PerformanceLogin is also tagged in these specs but the changes are specifically about the swap submission portion, so @PerformanceSwaps is the primary relevant tag.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit c8800ec May 7, 2026
98 of 126 checks passed
@pnarayanaswamy pnarayanaswamy deleted the submit-trx-flag branch May 7, 2026 15:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@javiergarciavera javiergarciavera javiergarciavera approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pnarayanaswamy @javiergarciavera