Skip to content

chore: remove sites arrow#29861

Merged
juanmigdr merged 2 commits into
mainfrom
chore/remove-sites-arrow
May 7, 2026
Merged

chore: remove sites arrow#29861
juanmigdr merged 2 commits into
mainfrom
chore/remove-sites-arrow

Conversation

@juanmigdr

@juanmigdr juanmigdr commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Removed sites arrows from sites tab

Changelog

CHANGELOG entry: removed sites arrows from sites tab

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that removes a decorative icon; behavior and navigation logic are unchanged.

Overview
Removes the Arrow2UpRight icon from site rows (SiteRowItem) and trending/recents tiles (SiteTileRowItem), simplifying the UI without changing click handling or navigation.

Reviewed by Cursor Bugbot for commit 68cf003. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-XS labels May 7, 2026
@juanmigdr juanmigdr removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 7, 2026
@juanmigdr juanmigdr enabled auto-merge May 7, 2026 14:18
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeBrowser
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files make purely cosmetic UI changes — both remove an Arrow2UpRight icon from site/dapp list item components:

  1. SiteRowItem.tsx (UI/Sites): Used in browser favorites/recents lists and the Trending view. Removing the arrow icon is a visual-only change with no functional impact.
  2. SiteTileRowItem.tsx (TrendingView/feeds/dapps): Used in the Trending view's dapps tab. Same cosmetic removal.

Impact areas:

  • SmokeWalletPlatform: The Trending view (DappsTab, ExplorePageV1, SiteTileRowItem) is directly tested by this tag. The icon removal could affect snapshot tests or visual assertions in Trending-related E2E tests.
  • SmokeBrowser: SiteRowItem is used in browser favorites/recents (useBrowserFavoritesSites, useBrowserRecentsSites), so browser-related E2E tests should be validated.

No logic, navigation, state management, or API changes were made. No controller or engine changes. No performance-sensitive code paths were modified. The risk is low and limited to visual rendering of these two components.

Performance Test Selection:
The changes are purely cosmetic (removing an icon from two UI components). No performance-sensitive code paths, list rendering logic, data fetching, state management, or initialization code was modified. Performance tests are not warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@juanmigdr juanmigdr added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 4bcdf93 May 7, 2026
141 of 145 checks passed
@juanmigdr juanmigdr deleted the chore/remove-sites-arrow branch May 7, 2026 15:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bergarces bergarces bergarces approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

Assignees

No one assigned

Labels

size-XS team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juanmigdr @bergarces @sahar-fehri