chore(rewards): fix campaign param extract#29856
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb916ab. Configure here.
Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This is a low-risk, additive change. No existing functionality is broken. The Performance Test Selection: |
|
|
|
||
| const pageParam = urlParams.get('page'); | ||
| const campaignParam = urlParams.get('campaign'); | ||
| const campaignParam = urlParams.get('campaign') ?? urlParams.get('~campaign'); |
There was a problem hiding this comment.
campaign is a reserved param and branch adds a tilde to it
Description
"?~campaign=ondo&__branch_flow_id=1580894552734833035&~referring_browser=Chrome" would fail to be parsed correctly, the campaign param we extract would be null, and the user would end up in the rewards dashboard instead of the ondo details campaign page.
Added support for upcoming perps trading comp deeplink
Changelog
CHANGELOG entry: null
Note
Low Risk
Low risk: small, localized change to rewards deeplink query parsing that may only affect navigation routing for rewards campaign links.
Overview
Rewards deeplink parsing now falls back to reading Branch-style
~campaignwhencampaignis missing, preventing campaign links from dropping users onto the generic rewards dashboard.It also expands allowed campaign values to include the new
perps-compcampaign so those deeplinks can route correctly.Reviewed by Cursor Bugbot for commit ddca21a. Bugbot is set up for automated code reviews on this repo. Configure here.