chore: centralize agent skills via Consensys/skills#29853
Conversation
Per ADR #57. Removes committed skills/rules now provided by Consensys/skills. Ignores agent dirs so engineers can mix synced (`mms-*`) and personal skills locally without git noise. Engineer entrypoint: `yarn skills` (calls scripts/skills-sync.sh, which delegates to Consensys/skills/tools/sync). Requires CONSENSYS_SKILLS_DIR env var; fails fast with setup instructions if unset. Removed (covered by mms- inject set): - 6 .cursor/rules/*.mdc (general-coding, e2e-testing, unit-testing, pr-creation, ui-development, deeplink-handler guidelines) - 2 .cursor/commands/ (create-ab-test, create-deeplink-handler) - 5 .claude/skills/ (ab-testing-implementation, component-view-test, e2e-test, performance-testing, pr-changelog) - 2 .claude/commands/ (create-ab-test, create-deeplink-handler) - 13 .agents/skills/ (the same 5 above plus pr-codeowners, pr-create, pr-description, pr-issue-search, pr-manual-testing, pr-readiness-check, pr-review-queue, pr-title) Kept (not centralized — internal): - .claude/skills/perps-core-sync, repo-skill-authoring - .cursor/skills/worktree-create - .claude/commands/{commit,lint-staged,setup-*,unit-test*, generate-claude-rules,create-bug}.md - All docs/ trees (perps, predict, readme), AGENTS.md files Companion PRs: - Consensys/skills#2 (source of truth + CLI) - MetaMask/decisions#162 (ADR amendment) - MetaMask/metamask-extension#42488 (parallel migration)
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
left a comment
There was a problem hiding this comment.
Looks like there are some unit tests that are failing, but overall I like this type of removal from the source code 👍
One request: if we haven't already documented how to set this up these skills in the repo itself in a README.md, can we please do this? It looks like some of this was documented in the PR description, but it should really be in the repo's README.md from devs to reference easily.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29853 +/- ##
===========================================
- Coverage 81.50% 43.28% -38.22%
===========================================
Files 5328 5328
Lines 141146 141146
Branches 32157 32157
===========================================
- Hits 115046 61101 -53945
- Misses 18239 74306 +56067
+ Partials 7861 5739 -2122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Centralization moved testing guides into Consensys/skills, but .cursor/BUGBOT.md, AGENTS.md, and tests/**/AGENTS.md mark these refs ALWAYS-mandatory and Cursor's bugbot service cannot run yarn skills. Restore unit-testing, e2e-testing, and component-view-tests guides under docs/testing/ as canonical in-repo copies; rewire all refs.
|
@gambinish — added an "AI Agent Skills ( |
Bare `.claude/{skills,commands}/` directory ignores blocked re-adding
the kept files (`perps-core-sync`, `repo-skill-authoring`, 9 commands)
after an accidental `git rm`. Switch to `*` patterns and explicit `!`
carve-outs to match the `.cursor/` carve-out shape.
`.skills.local` is auto-generated per engineer by `yarn skills` and holds the local `SKILLS_DOMAINS=` preference. Ignore it and ship a documented `.skills.local.example` so engineers know how to set it.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc1764b. Configure here.
racitores
left a comment
There was a problem hiding this comment.
Leave the review with request changes just to make sure that questions are clarified
|
@jvbriones — added a short note in 4114357. Kept it minimal: "Keep that checkout on |
Move check-ab-testing-compliance.sh out of the deleted .agents/ tree into scripts/ so the unit test and BUGBOT can run it without yarn skills.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
None of these changes affect:
No E2E tests need to run for this PR. Performance Test Selection: |
|




Description
Per ADR #57. Removes committed agent skills/rules now provided by the centralized
Consensys/skillsrepo. Addsyarn skillsto install them on demand..cursor/,.claude/, and.agents/. Synced sets land viayarn skills; nothing under those dirs is tracked anymore..gitignoreblocks the agent dirs entirely. Only.cursor/BUGBOT.md,.cursor/hooks.json, and.cursor/worktrees.jsonare carved out (IDE/bugbot config that must stay tracked).yarn skillscallsscripts/skills-sync.sh, which requiresCONSENSYS_SKILLS_DIRto be set; falls back to setup instructions if not configured..skills.local(per-engineerSKILLS_DOMAINS=config) is gitignored;.skills.local.exampleis committed as a template.Kept (in-repo, not under agent dirs)
docs/trees (perps, predict, readme),AGENTS.mdfilesdocs/testing/{unit-testing,e2e-testing,component-view-tests}.md(see next section)In-repo testing guides (
docs/testing/).cursor/BUGBOT.mdis read by Cursor's BUGBOT service, which cannot runyarn skillsto fetch the centralizedmms-*set. SeveralAGENTS.mdfiles also mark the testing guides ALWAYS-mandatory and need a stable in-repo path.To keep BUGBOT enforcement working without re-importing the deleted skill structure, the three test guides live as plain docs under
docs/testing/:docs/testing/unit-testing.mddocs/testing/e2e-testing.mddocs/testing/component-view-tests.md(consolidated SKILL.md + 3 references)The same guidance also reaches IDE harnesses via
Consensys/skills+yarn skills. These docs are the canonical fallback for tools that can't run the sync.Engineer setup (one time)
Then in this repo:
Companion PRs
Consensys/skills#2— source of truth, install CLI, sync wrapper.MetaMask/metamask-extension#42488— parallel migration.MetaMask/decisions#162— ADR amendment.Out of scope
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
No UI change — agent tooling and repo wiring only.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk since changes are limited to developer/agent tooling, but could disrupt local workflows if
CONSENSYS_SKILLS_DIRisn’t configured or the sync script behaves unexpectedly.Overview
Removes the previously committed agent skills/commands/rules under
.agents/skills/and.claude/(and related Cursor command stubs), shifting to an external, on-demand install model.Adds
yarn skills(viascripts/skills-sync.sh) to delegate syncing toConsensys/skillsusingCONSENSYS_SKILLS_DIR, and updates.gitignoreto fully ignore agent-managed directories while carving out tracked Cursor config files like.cursor/BUGBOT.md.Updates
.cursor/BUGBOT.mdto reference the new in-repo testing docs underdocs/testing/instead of the removed rule paths.Reviewed by Cursor Bugbot for commit a7d327f. Bugbot is set up for automated code reviews on this repo. Configure here.