Skip to content

chore: bullets sync during swipe and full-width sources sheet#29851

Merged
zone-live merged 8 commits into
mainfrom
TSA-sync-bullets-with-animation-and-position-bottomSheet
May 7, 2026
Merged

chore: bullets sync during swipe and full-width sources sheet#29851
zone-live merged 8 commits into
mainfrom
TSA-sync-bullets-with-animation-and-position-bottomSheet

Conversation

@zone-live

@zone-live zone-live commented May 7, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

3 polish fixes for the What's Happening detail view:

Dots in sync with swipe, the active dot now flips the moment the next card crosses 50% during the drag, instead of lagging until the snap animation settles.
Sources bottom sheet is now full-width.
Navigation to specific card index is working again.

Simulator Screenshot - iPhone 17 Pro - 2026-05-07 at 10 46 08

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adjusts carousel scroll handling and analytics triggers, and changes how the sources bottom sheet is presented; regressions could affect navigation to an initial card, page indicator accuracy, or event tracking.

Overview
Improves the What’s Happening detail carousel by updating the page indicator live during drag via onScroll, while only firing WHATS_HAPPENING_VIEWED analytics on onMomentumScrollEnd after snap settling.

Fixes initial-card navigation by scrolling to initialIndex on onContentSizeChange once the content is wide enough, guarded to run only once.

Moves the sources bottom sheet out of WhatsHappeningExpandedCard into WhatsHappeningDetailView (card now emits onSourcesPress with articles), enabling a full-width sheet anchored at the screen root; tests were updated/added to cover these behaviors.

Reviewed by Cursor Bugbot for commit c126348. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 7, 2026
@github-actions github-actions Bot added the size-S label May 7, 2026
@github-actions github-actions Bot added size-M and removed size-S labels May 7, 2026
@zone-live zone-live enabled auto-merge May 7, 2026 11:34
cursor[bot]
cursor Bot reviewed May 7, 2026
View reviewed changes
Comment thread app/components/Views/WhatsHappeningDetailView/WhatsHappeningDetailView.test.tsx
cursor[bot]
cursor Bot reviewed May 7, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dd4bdec. Configure here.

Comment thread app/components/Views/WhatsHappeningDetailView/WhatsHappeningDetailView.tsx
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the WhatsHappeningDetailView and its WhatsHappeningExpandedCard component. The key changes are:

  1. Bottom sheet lifting: The WhatsHappeningSourcesBottomSheet was moved from being rendered inside each card (within a ScrollView) to being rendered at the screen root level in WhatsHappeningDetailView. This fixes a UI anchoring issue where the bottom sheet was constrained by the card's positioning context.

  2. Scroll behavior improvement: Initial scroll to initialIndex was changed from a useEffect approach to an onContentSizeChange callback with a guard ref (hasScrolledToInitial), preventing multiple scroll attempts.

  3. Live dot indicator: Added onScroll handler to update the page indicator dot in real-time during drag (previously only updated on momentum end via handleScrollEnd). The setCurrentIndex call was removed from handleScrollEnd to avoid double-updates.

These are UI-only refactoring changes with no impact on core controllers, Engine, or critical infrastructure. The WhatsHappening feature is part of the Trending/Homepage section (SmokeWalletPlatform). The expanded card contains PerpsRow components, and per the SmokePerps tag description, changes to Perps views embedded in Trending affect both SmokePerps and SmokeWalletPlatform. No other tags are impacted.

Performance Test Selection:
The changes are UI refactoring (bottom sheet lifting and scroll behavior improvements) with no significant performance impact. No new rendering loops, heavy computations, or data loading changes were introduced. The scroll optimization (onContentSizeChange vs useEffect) is actually a minor improvement but not worth running dedicated performance tests for.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 14422ab May 7, 2026
94 checks passed
@zone-live zone-live deleted the TSA-sync-bullets-with-animation-and-position-bottomSheet branch May 7, 2026 15:59
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@joaosantos15 joaosantos15 joaosantos15 approved these changes

Assignees

No one assigned

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zone-live @joaosantos15