Skip to content

chore: remove unused SegmentedControl temp component#29846

Merged
brianacnguyen merged 3 commits into
mainfrom
remove-segmented-control-temp-component
May 15, 2026
Merged

chore: remove unused SegmentedControl temp component#29846
brianacnguyen merged 3 commits into
mainfrom
remove-segmented-control-temp-component

Conversation

@AndyMBridges

@AndyMBridges AndyMBridges commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the unused temporary SegmentedControl component from app/component-library/components-temp/SegmentedControl.

This also removes the stale Storybook registration entry for its story. A reference search confirms there are no remaining app, test, or Storybook references.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: temporary component cleanup

  Scenario: SegmentedControl temp component is removed
    Given the repository is on this branch
    When searching for SegmentedControl temp component references
    Then no app, test, or Storybook references are found

Screenshots/Recordings

N/A. Code cleanup only.

Before

N/A

After

N/A

Validation

  • rg -n "components-temp/SegmentedControl|SegmentedControl" app tests .storybook --glob '!node_modules/**' returned no matches.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk cleanup that only deletes an unused temp UI component and its Storybook wiring; primary risk is accidental removal if any downstream consumer existed outside the searched paths.

Overview
Removes the temporary components-temp/SegmentedControl component entirely (implementation, types/constants, styles, tests, README, and Storybook story).

Updates Storybook’s auto-generated storybook.requires.js to drop the stale import/registration for the deleted SegmentedControl story.

Reviewed by Cursor Bugbot for commit 2b847b4. Bugbot is set up for automated code reviews on this repo. Configure here.

@AndyMBridges AndyMBridges self-assigned this May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-core-extension-ux Core Extension UX team label May 7, 2026
@AndyMBridges AndyMBridges removed their assignment May 7, 2026
@AndyMBridges AndyMBridges marked this pull request as ready for review May 7, 2026 08:55
@AndyMBridges AndyMBridges requested a review from a team as a code owner May 7, 2026 08:55
@AndyMBridges AndyMBridges added team-design-system All issues relating to design system in Mobile and removed team-core-extension-ux Core Extension UX team labels May 8, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR deletes the SegmentedControl component from app/component-library/components-temp/SegmentedControl/. All 9 changed files are part of this single component's deletion: the component implementation, types, styles, constants, stories, unit tests, README, index export, and the storybook registry entry. Grep searches confirm zero usages of SegmentedControl anywhere else in the codebase — no app code imports it, no E2E tests reference it, and no user-facing flows depend on it. This is a pure dead-code cleanup with no impact on any user flows, controllers, or E2E test scenarios. No E2E tags are warranted.

Performance Test Selection:
Deleting an unused component library component has no performance impact on any app flows. No performance tests are needed.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@brianacnguyen brianacnguyen added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 5b1913f May 15, 2026
59 of 62 checks passed
@brianacnguyen brianacnguyen deleted the remove-segmented-control-temp-component branch May 15, 2026 16:56
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XL team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants