Skip to content

chore: remove unused QuickActionButtons temp component#29845

Merged
brianacnguyen merged 7 commits into
mainfrom
remove-quick-action-buttons-temp-component
May 15, 2026
Merged

chore: remove unused QuickActionButtons temp component#29845
brianacnguyen merged 7 commits into
mainfrom
remove-quick-action-buttons-temp-component

Conversation

@AndyMBridges

@AndyMBridges AndyMBridges commented May 7, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Removes the unused temporary QuickActionButtons component from app/component-library/components-temp/QuickActionButtons.

This also removes the nested QuickActionButton component, which was only used by QuickActionButtons, and removes stale Storybook registration entries for both stories.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: temporary component cleanup

  Scenario: QuickActionButtons temp component is removed
    Given the repository is on this branch
    When searching for QuickActionButtons temp component references
    Then no app, test, or Storybook references are found

Screenshots/Recordings

N/A. Code cleanup only.

Before

N/A

After

N/A

Validation

  • rg -n "components-temp/QuickActionButtons|QuickActionButtons" app tests .storybook --glob '!node_modules/**' returned no matches.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk cleanup that only deletes an unused temporary component and its Storybook/tests; primary risk is breaking any hidden imports if they existed.

Overview
Removes the temporary components-temp/QuickActionButtons implementation (including the nested QuickActionButton), along with their associated unit tests and Storybook stories.

Updates the auto-generated .storybook/storybook.requires.js to drop the stale story registrations for these removed stories.

Reviewed by Cursor Bugbot for commit 8ba4b53. Bugbot is set up for automated code reviews on this repo. Configure here.

@AndyMBridges AndyMBridges self-assigned this May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-core-extension-ux Core Extension UX team label May 7, 2026
@AndyMBridges AndyMBridges removed their assignment May 7, 2026
@github-actions github-actions Bot added the size-L label May 7, 2026
@AndyMBridges AndyMBridges marked this pull request as ready for review May 7, 2026 08:55
@AndyMBridges AndyMBridges requested a review from a team as a code owner May 7, 2026 08:55
@AndyMBridges AndyMBridges added team-design-system All issues relating to design system in Mobile and removed team-core-extension-ux Core Extension UX team labels May 8, 2026
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a pure deletion of the QuickActionButtons component library from app/component-library/components-temp/. All 11 changed files are being removed: the QuickActionButtons container component, QuickActionButton sub-component, their TypeScript types, Storybook stories, unit tests, index files, and the storybook.requires.js entry.

Investigation confirmed:

  1. No other files in the codebase import or reference QuickActionButtons/QuickActionButton from this path (grep returned zero matches for 'components-temp/QuickActionButtons' and 'QuickActionButton' in .tsx files)
  2. The component was in components-temp (temporary/experimental), indicating it was not yet integrated into production app flows
  3. The only 'QuickActionButton' reference found in tests/page-objects/Trending/TrendingView.ts is a completely different method (getQuickActionButton) that uses testID selectors, unrelated to this component
  4. No controllers, Engine, navigation, modals, confirmations, or any critical user-facing paths are affected
  5. This is a clean component library cleanup with zero impact on E2E test flows

No E2E tests need to run for this change as it removes unused/temporary UI components with no production app impact.

Performance Test Selection:
The deleted QuickActionButtons component was in components-temp and not used in any production app flows. No rendering, state management, or critical user flow performance is affected by this deletion.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 14, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 89d5d6c May 15, 2026
100 of 102 checks passed
@brianacnguyen brianacnguyen deleted the remove-quick-action-buttons-temp-component branch May 15, 2026 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirillzyusko kirillzyusko kirillzyusko approved these changes

Assignees

No one assigned

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-L team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyMBridges @kirillzyusko @brianacnguyen