Skip to content

chore: remove unused NonEvmAggregatedPercentage temp component#29844

Merged
brianacnguyen merged 4 commits into
mainfrom
remove-non-evm-aggregated-percentage-temp-component
May 15, 2026
Merged

chore: remove unused NonEvmAggregatedPercentage temp component#29844
brianacnguyen merged 4 commits into
mainfrom
remove-non-evm-aggregated-percentage-temp-component

Conversation

@AndyMBridges

@AndyMBridges AndyMBridges commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the unused temporary NonEvmAggregatedPercentage component from app/component-library/components-temp/Price/AggregatedPercentage.

A reference search confirms there are no remaining app, test, or Storybook references.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: temporary component cleanup

  Scenario: NonEvmAggregatedPercentage temp component is removed
    Given the repository is on this branch
    When searching for NonEvmAggregatedPercentage references
    Then no app, test, or Storybook references are found

Screenshots/Recordings

N/A. Code cleanup only.

Before

N/A

After

N/A

Validation

  • rg -n "NonEvmAggregatedPercentage" app tests .storybook --glob '!node_modules/**' returned no matches.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk cleanup that only deletes an unused temporary component and its unit test, with no remaining references in the app.

Overview
Removes the temporary NonEvmAggregatedPercentage component and its corresponding test from components-temp/Price/AggregatedPercentage.

Reviewed by Cursor Bugbot for commit c361aa3. Bugbot is set up for automated code reviews on this repo. Configure here.

@AndyMBridges AndyMBridges self-assigned this May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-core-extension-ux Core Extension UX team label May 7, 2026
@AndyMBridges AndyMBridges removed their assignment May 7, 2026
@github-actions github-actions Bot added the size-M label May 7, 2026
@AndyMBridges AndyMBridges marked this pull request as ready for review May 7, 2026 08:55
@AndyMBridges AndyMBridges requested a review from a team as a code owner May 7, 2026 08:55
@AndyMBridges AndyMBridges added team-design-system All issues relating to design system in Mobile and removed team-core-extension-ux Core Extension UX team labels May 8, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
Both changed files are being DELETED (not modified):

  1. NonEvmAggregatedPercentage.tsx - component file deleted
  2. NonEvmAggregatedPercentage.test.tsx - unit test file deleted

Key findings:

  • No importers found anywhere in the codebase for NonEvmAggregatedPercentage - the component was already decoupled before deletion
  • The AggregatedPercentage directory still contains AggregatedPercentageCrossChains.tsx, suggesting the functionality was consolidated there
  • This is a pure cleanup/dead code removal with no active consumers

Since no code currently imports or uses this deleted component, there is no risk of breaking any existing functionality or E2E tests. No E2E test tags are needed.

Performance Test Selection:
The deleted component was a UI display component for non-EVM aggregated percentage changes. Since it has no importers and is being deleted (not modified), there is no performance impact to measure.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@brianacnguyen brianacnguyen added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 990e610 May 15, 2026
60 of 62 checks passed
@brianacnguyen brianacnguyen deleted the remove-non-evm-aggregated-percentage-temp-component branch May 15, 2026 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-M team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants