fix: add token image fallback in AssetLogo (ASSETS-3156)#29827
Conversation
Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: AssetLogo is used across many components:
Per tag descriptions: SmokeSwap and SmokeStake require SmokeConfirmations. SmokeMoney is included for CardAssetItem usage. The change is low risk — it's purely a UI fallback for missing token images, with proper validation guards (chainId format checks). No controller, Engine, navigation, or state management changes. Performance Test Selection: |
|



Description
This PR fixes token logo rendering for non-native assets when
asset.imageis empty (the issue affecting mUSD/Money integration).The
AssetLogocomponent now:getAssetImageUrlwhen the primary image is missing,imageSource={{ uri: imageUri }}so undefined URI values are handled directly byAvatarToken.It also adds unit tests to cover fallback behavior and unsupported chain-id behavior.
Changelog
CHANGELOG entry: fix: fixed token list items to use a fallback icon when token image URLs are missing
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3156
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist