Skip to content

test: 2/3 Remove wdio folder: Migrate helpers out of wdio folder into tests folder#29826

Merged
cortisiko merged 3 commits into
mainfrom
MMQA-1801
May 7, 2026
Merged

test: 2/3 Remove wdio folder: Migrate helpers out of wdio folder into tests folder#29826
cortisiko merged 3 commits into
mainfrom
MMQA-1801

Conversation

@cortisiko

@cortisiko cortisiko commented May 6, 2026

Copy link
Copy Markdown
Member

Description

Migrates test utilities away from the legacy wdio folder by deleting wdio/helpers/Accounts.js and introducing a typed replacement tests/utils/Accounts.ts, then updating affected flows/tests to import from the new location.

Cleans up test framework remnants by removing tests/framework/utils/Flows.js and updating page objects/selectors to use app-owned test IDs (e.g., adds/uses SecurityPrivacyViewSelectorsIDs.DELETE_WALLET_BUTTON and switches Change Password confirm input to ChoosePasswordSelectorsIDs.CONFIRM_PASSWORD_INPUT_ID). Also updates swaps QuoteView to source getAssetTestId from the new selectors module.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Test-only refactors that change helper locations and test IDs; risk is limited to CI test failures if selectors/IDs drift from the app UI.

Overview
Migrates test utilities away from the legacy wdio folder by deleting wdio/helpers/Accounts.js, adding a typed replacement tests/utils/Accounts.ts, and updating flows/regression tests to import it from the new location.

Removes the unused legacy tests/framework/utils/Flows.js helper module.

Aligns Detox page objects with app-owned test IDs/selectors: adds SecurityPrivacyViewSelectorsIDs.DELETE_WALLET_BUTTON, updates SecurityAndPrivacyView to use it, switches Change Password confirm input to ChoosePasswordSelectorsIDs.CONFIRM_PASSWORD_INPUT_ID, and updates swaps QuoteView to import getAssetTestId from the new WalletView selectors module.

Reviewed by Cursor Bugbot for commit 027d2eb. Bugbot is set up for automated code reviews on this repo. Configure here.

@cortisiko cortisiko requested review from a team as code owners May 6, 2026 21:58
@cortisiko cortisiko changed the title test: 2/3 Remove wdio folder 2/3: Migrate helpers out of wdio folder into tests folder test: 2/3 Remove wdio folder: Migrate helpers out of wdio folder into tests folder May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 6, 2026
@github-actions github-actions Bot added the size-M label May 6, 2026
@cortisiko cortisiko added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels May 6, 2026

@vinnyhoward vinnyhoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown

@cortisiko cortisiko added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 37918d8 May 7, 2026
112 of 114 checks passed
@cortisiko cortisiko deleted the MMQA-1801 branch May 7, 2026 14:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants