Skip to content

test: 1/3 remove wdio folder dependencies#29820

Merged
cortisiko merged 2 commits into
mainfrom
MMQA-1799
May 6, 2026
Merged

test: 1/3 remove wdio folder dependencies#29820
cortisiko merged 2 commits into
mainfrom
MMQA-1799

Conversation

@cortisiko

@cortisiko cortisiko commented May 6, 2026

Copy link
Copy Markdown
Member

Description

Removes the WDIO generateTestId helper and updates many UI components to pass testID directly (dropping Platform-dependent spreading) across buttons, toggles, list items, and modals.

Introduces/standardizes colocated *.testIds.ts selector constants for several screens/components (e.g., Navbar, EthereumAddress, AccountSelector, BrowserTab options, PhishingModal, WebviewError, TermsAndConditions, ConnectQRHardware) and updates unit tests/components to import selectors from the new tests/selectors/local testId modules instead of wdio paths.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk refactor focused on test selectors: changes only how testIDs are assigned and referenced, with minimal runtime impact beyond potential selector/name mismatches in tests/automation.

Overview
Removes the WDIO generateTestId utility and updates multiple UI components to pass testID directly (dropping Platform-dependent spreading) across buttons, toggles, list items, and modals.

Introduces/standardizes co-located *.testIds.ts selector constants (e.g., Navbar, EthereumAddress, AccountSelector, browser options, phishing/webview error modals, terms, QR hardware connect) and updates unit tests/components to import selectors from these modules (and from tests/selectors) instead of wdio paths.

Reviewed by Cursor Bugbot for commit 7d696af. Bugbot is set up for automated code reviews on this repo. Configure here.

@cortisiko cortisiko requested review from a team as code owners May 6, 2026 19:15
@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 6, 2026
@github-actions github-actions Bot added the size-M label May 6, 2026
@cortisiko cortisiko added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run labels May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 6, 2026

Copy link
Copy Markdown

@cortisiko cortisiko enabled auto-merge May 6, 2026 21:08
@cortisiko cortisiko added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 0b6a6a0 May 6, 2026
114 checks passed
@cortisiko cortisiko deleted the MMQA-1799 branch May 6, 2026 21:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants