Conversation
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
Prithpal-Sooriya
approved these changes
May 6, 2026
brianacnguyen
approved these changes
May 6, 2026
|
infiniteflower
approved these changes
May 6, 2026
Brunonascdev
approved these changes
May 6, 2026
vinnyhoward
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk refactor focused on test selectors: changes only how
testIDs are assigned and referenced, with minimal runtime impact beyond potential selector/name mismatches in tests/automation.Overview
Removes the WDIO
generateTestIdutility and updates multiple UI components to passtestIDdirectly (droppingPlatform-dependent spreading) across buttons, toggles, list items, and modals.Introduces/standardizes co-located
*.testIds.tsselector constants (e.g.,Navbar,EthereumAddress,AccountSelector, browser options, phishing/webview error modals, terms, QR hardware connect) and updates unit tests/components to import selectors from these modules (and fromtests/selectors) instead ofwdiopaths.Reviewed by Cursor Bugbot for commit 7d696af. Bugbot is set up for automated code reviews on this repo. Configure here.