feat: update client id#29776
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c3844b5. Configure here.
| }, | ||
| main_prod: { | ||
| IOS_GOOGLE_CLIENT_ID: | ||
| '795351133007-jcaor637tblrlpuj29shdej3co8bu8kv.apps.googleusercontent.com', |
There was a problem hiding this comment.
not correct. Should be: http://795351133007-47aohp9j9n7r8fef5n6ejeauhu4kfc9e.apps.googleusercontent.com/
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: This change directly impacts:
The risk is medium because: the change is a straightforward refactoring (env vars → config object), the values appear correct (matching what was in .js.env.example), and unit tests have been updated to validate the new approach. However, the OAuth flow is critical for seedless onboarding users and any misconfiguration could break authentication entirely. Performance Test Selection: |
|




Description
OAuth client IDs for Google and Apple sign-in (
IOS_GOOGLE_CLIENT_ID,IOS_GOOGLE_REDIRECT_URI,ANDROID_GOOGLE_CLIENT_ID,ANDROID_GOOGLE_SERVER_CLIENT_ID,ANDROID_APPLE_CLIENT_ID) were previously sourced fromprocess.env, requiring manual environment variable configuration and risking misconfiguration across different build types.This PR moves those client IDs into the existing
OAUTH_CONFIGobject inconfig.ts, keyed by build type (development, main_prod, main_uat, main_dev, flask_prod, flask_uat, flask_dev). The constants inconstants.tsnow read fromCURRENT_OAUTH_CONFIGinstead ofprocess.env, ensuring the correct client IDs are automatically selected based on the build type. The corresponding environment variable entries have been removed from.js.env.example.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches OAuth configuration used for Google/Apple login; incorrect client IDs/redirect URIs could break authentication in specific build targets despite being mostly a config refactor.
Overview
OAuth client IDs/redirect URIs are now defined per build type in
OAuthLoginHandlers/config.tsand consumed viaCURRENT_OAUTH_CONFIGinconstants.ts, instead of being read fromprocess.env.The example env file removes the seedless-onboarding client ID entries, and unit tests are updated to assert against
OAUTH_CONFIG.main_prodvalues for Android and legacy iOS Google config selection.Reviewed by Cursor Bugbot for commit fd46114. Bugbot is set up for automated code reviews on this repo. Configure here.