Skip to content

chore(runway): cherry-pick test: add automated build environment display to RC and production builds.#29731

Merged
chloeYue merged 2 commits into
release/7.76.0from
runway-cherry-pick-7.76.0-1777988002
May 5, 2026
Merged

chore(runway): cherry-pick test: add automated build environment display to RC and production builds.#29731
chloeYue merged 2 commits into
release/7.76.0from
runway-cherry-pick-7.76.0-1777988002

Conversation

@runway-github

@runway-github runway-github Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

Adds automated build environment display to RC and production builds.
Captures actual environment values used during builds
(METAMASK_ENVIRONMENT, METAMASK_BUILD_TYPE, API URLs, etc.) and displays
them:

  • RC builds: In PR comment alongside build links
  • Prod builds: Extracted via new workflow (Slack notification in
    follow-up PR).

Changes:

  • scripts/apply-build-config.js: Add --write-build-env flag to generate
    build-env.json with actual env values
  • build.yml: Generate and upload build-env.json as artifact during
    builds (used by both RC and
    prod)
  • build-rc-auto.yml: Download build-env artifacts in
    post-rc-build-comment job
  • scripts/build-announce/: Add env section to RC build PR comments
  • prod-build-env-notify.yml: New workflow triggered on prod build
    completion, extracts env values (Slack posting in follow-up PR)

Changelog

CHANGELOG entry: null

Related issues

Fixes:
https://consensyssoftware.atlassian.net/browse/MMQA-1108

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes CI build workflows and the RC PR-comment pipeline to generate,
upload, download, and parse a new build-env.json artifact;
misconfiguration could break build jobs or PR comment posting. Risk is
limited to CI/reporting paths and is largely non-blocking
(continue-on-error/|| true) but still touches release build
automation.

Overview
Adds generation of a build-env.json file during CI builds (via
scripts/apply-build-config.js --write-build-env) and uploads it as a
build artifact for each platform.

Updates RC automation to download these artifacts and extends
scripts/build-announce to parse them and include a Build
Environment
section (env/build type, remote FF mapping, key API
URLs/flags) in the RC PR comment, with a fallback “not available”
section on extraction failure.

Introduces a new Prod Build Env Notify workflow that triggers on
successful production workflow runs, downloads the build-env artifact,
extracts key values with jq, and currently prints a placeholder for a
future Slack notification; also ignores local build-env.json via
.gitignore.

Reviewed by Cursor Bugbot for commit
0f0c4b5. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[862bf76](https://github.com/MetaMask/metamask-mobile/commit/862bf7619e11a37bd13c54fe5e402b314e1df073)

…lay to RC and production builds. (#29390)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**
Adds automated build environment display to RC and production builds.
Captures actual environment values used during builds
(METAMASK_ENVIRONMENT, METAMASK_BUILD_TYPE, API URLs, etc.) and displays
them:
- RC builds: In PR comment alongside build links
- Prod builds: Extracted via new workflow (Slack notification in
follow-up PR).
 
**Changes:**
- scripts/apply-build-config.js: Add --write-build-env flag to generate
build-env.json with actual env values
- build.yml: Generate and upload build-env.json as artifact during
builds (used by both RC and
prod)
- build-rc-auto.yml: Download build-env artifacts in
post-rc-build-comment job
- scripts/build-announce/: Add env section to RC build PR comments
- prod-build-env-notify.yml: New workflow triggered on prod build
completion, extracts env values (Slack posting in follow-up PR)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:
https://consensyssoftware.atlassian.net/browse/MMQA-1108
## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes CI build workflows and the RC PR-comment pipeline to generate,
upload, download, and parse a new `build-env.json` artifact;
misconfiguration could break build jobs or PR comment posting. Risk is
limited to CI/reporting paths and is largely non-blocking
(`continue-on-error`/`|| true`) but still touches release build
automation.
> 
> **Overview**
> Adds generation of a `build-env.json` file during CI builds (via
`scripts/apply-build-config.js --write-build-env`) and uploads it as a
build artifact for each platform.
> 
> Updates RC automation to download these artifacts and extends
`scripts/build-announce` to parse them and include a **Build
Environment** section (env/build type, remote FF mapping, key API
URLs/flags) in the RC PR comment, with a fallback “not available”
section on extraction failure.
> 
> Introduces a new `Prod Build Env Notify` workflow that triggers on
successful production workflow runs, downloads the `build-env` artifact,
extracts key values with `jq`, and currently prints a placeholder for a
future Slack notification; also ignores local `build-env.json` via
`.gitignore`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
0f0c4b5. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner May 5, 2026 13:33
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 5, 2026
@github-actions github-actions Bot added the size-M label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue merged commit 38d122b into release/7.76.0 May 5, 2026
103 of 105 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.76.0-1777988002 branch May 5, 2026 14:48
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants