Skip to content

fix: transaction page display and alerts for money account transactions#29725

Merged
jpuri merged 1 commit into
mainfrom
conf_pages_fix
May 5, 2026
Merged

fix: transaction page display and alerts for money account transactions#29725
jpuri merged 1 commit into
mainfrom
conf_pages_fix

Conversation

@jpuri

@jpuri jpuri commented May 5, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fix transaction page display and alerts for money account transactions

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1342

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Expands several transaction-type conditionals to include moneyAccountDeposit/moneyAccountWithdraw, including post-quote config for withdrawals, which could affect how pay/withdraw transactions are labeled and configured. Coverage is improved with new unit tests, but regressions are possible if type routing is incomplete or mislabeled.

Overview
Improves confirmations/activity transaction details handling for money account transactions by treating moneyAccountDeposit/moneyAccountWithdraw as supported types across the hero amount, summary routing, account row, and fee/total rows (including using provider fee labeling and receive-type totals where appropriate).

Updates pay-related behavior so money-account withdrawals are excluded from insufficient-balance alerts, included in signed/submitted pay-type checks (for deposits), and avoid setting refundTo/isHyperliquidSource in useTransactionPayPostQuote.

Adds/extends unit tests to cover the new money-account deposit/withdraw cases and the updated fallbacks/labels.

Reviewed by Cursor Bugbot for commit 08b5327. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri jpuri requested a review from a team as a code owner May 5, 2026 12:07
@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge May 5, 2026 12:07
@github-actions github-actions Bot added the size-M label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney, SmokeConfirmations, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 20 changed files are in the confirmations activity/hooks area and exclusively add support for two new TransactionType values: moneyAccountDeposit and moneyAccountWithdraw — MetaMask Card (Money) transaction types.

Changes breakdown:

  1. Transaction details UI components (hero, summary, account-row, bridge-fee-row, network-fee-row, total-row): Added moneyAccountDeposit/moneyAccountWithdraw to their supported/fallback/receive type lists — these are the activity detail screens shown after a Money account deposit or withdrawal.
  2. PayTokenAmount component: Excludes moneyAccountDeposit from rendering the token amount (it has a custom UI), consistent with how perps/predict deposits work.
  3. useInsufficientBalanceAlert: Ignores balance check for moneyAccountWithdraw (similar to perpsWithdraw).
  4. useSignedOrSubmittedAlert: Adds moneyAccountDeposit to PAY_TYPES for hardware wallet flow handling.
  5. useTransactionConfirm: Adds moneyAccountDeposit/moneyAccountWithdraw to GO_BACK_TYPES (post-confirmation navigation).
  6. useTransactionPayPostQuote: Handles moneyAccountWithdraw like perpsWithdraw — no refundTo address (funds go directly to user's address).

Tag selection rationale:

  • SmokeMoney: Primary tag — these changes directly implement Money account deposit/withdraw confirmation flows. The Card Add Funds (Deposit) and withdrawal flows are the core feature being modified.
  • SmokeConfirmations: Required — changes touch core confirmation hooks (useTransactionConfirm, useInsufficientBalanceAlert, useSignedOrSubmittedAlert, useTransactionPayPostQuote) and activity detail components that are shared across all confirmation flows. Regression risk to existing confirmation flows (perps, predict, musd) is present since type lists are being modified.
  • SmokeWalletPlatform: Required per SmokeMoney tag description — when changes touch wallet home or actions entry to buy/sell, also select SmokeWalletPlatform. Activity display (transaction history) is also affected by the transaction-details components.

The changes are well-scoped (only adding new transaction types to existing type-check lists) with no logic changes to existing flows, making this medium risk rather than high.

Performance Test Selection:
These changes are purely additive — adding new TransactionType values to existing type-check arrays in confirmation UI components and hooks. There are no changes to rendering logic, list components, data fetching, state management, or app initialization that would impact performance metrics. No performance tests are warranted.

View GitHub Actions results

cursor[bot]
cursor Bot reviewed May 5, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 08b5327. Configure here.

Comment thread ...components/activity/transaction-details-account-row/transaction-details-account-row.test.tsx
@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pedronfigueiredo pedronfigueiredo self-requested a review May 5, 2026 14:25
@jpuri jpuri added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 0b8d638 May 5, 2026
196 of 198 checks passed
@jpuri jpuri deleted the conf_pages_fix branch May 5, 2026 15:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpuri @pedronfigueiredo