chore: explore v2 nit fixes#29720
Conversation
…wn in perps section
|
@cursor look at all my commits in this PR and create a nice bulletpointed summary of the changes this PR fixes |
|
Now I have all the information needed to create a comprehensive summary. Based on the commits and changes I've analyzed, here's the bulletpointed summary of what this PR fixes: Summary of Changes in PR: Chore/explore v2 nits🔗 Browser URL Display Improvements
🏈 Sports Section UI/UX Enhancements
⚡ Performance Optimizations
🎯 Filter Propagation Enhancement
🧪 Testing & Code Quality
These changes collectively improve the user experience in the Explore/Trending sections by providing more informative URL displays, better performance, and enhanced navigation filtering capabilities. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 238b272. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Browser Sites Changes (useBrowserFavoritesSites, useBrowserRecentsSites, useSitesData):
TrendingView - Perps (MacroTab, RwasTab, PillToggleCardList):
TrendingView - Predictions (SportsTab, useSportsMarketsFeed):
Dependent tags (per tag descriptions):
No changes to core controllers, Engine, navigation infrastructure, or account/network management — so SmokeAccounts, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeMoney, SmokeMultiChainAPI, SmokeSnaps, SmokeSeedlessOnboarding are not needed. Performance Test Selection: |
|





Description
🔗 Browser URL Display Improvements
app.uniswap.org/swap?chain=1instead of justuniswap.org)🏈 Sports Section UI/UX Enhancements
trending.soccertotrending.footballfor more universal terminologyPredictionCarouselRowItemtoPredictMarketcomponent for better visual consistency in the active sports markets list⚡ Performance Optimizations
FlashListwith header and footer components for better performanceRefreshControlfor improved user interaction in the Sports Tab🎯 Filter Propagation Enhancement
PillToggleCardListcomponent and propagate the active filter when navigating from Macro/RWA tabs to the perps market listPillToggleCardListwithonPillChangecallback to enable parent components to track active selections🧪 Testing & Code Quality
extractFullDisplayUrlfunction with proper documentation and test coverageChangelog
CHANGELOG entry: solved nit issues in explore v2
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3145
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk due to a non-trivial refactor of the Sports tab to a single
FlashListwith new refresh/load-more wiring, plus changes that affect perps navigation filtering behavior. URL display changes are low risk but touch shared site/query matching utilities.Overview
Improves Explore URL labeling by introducing
extractFullDisplayUrland switching browser favorites and recents to display host+path+query (while keeping curated site cards on hostname-onlyextractDisplayUrl), with updated/added unit tests.Enhances Trending Explore UX by refactoring
SportsTabinto a singleFlashListwith header/footer, pull-to-refresh, and usingPredictMarketrows for the “All Sports” list; also renames the soccer label key totrending.football.Adds an
onPillChangecallback toPillToggleCardListand updatesMacroTab/RwasTabto pass the active pill as a filter when navigating to the perps market list.Reviewed by Cursor Bugbot for commit 41f7071. Bugbot is set up for automated code reviews on this repo. Configure here.