Skip to content

chore: Remove permissions settings feature flag#29685

Merged
adonesky1 merged 1 commit into
mainfrom
wapi-1468-remove-permissions-flag
May 4, 2026
Merged

chore: Remove permissions settings feature flag#29685
adonesky1 merged 1 commit into
mainfrom
wapi-1468-remove-permissions-flag

Conversation

@adonesky1

@adonesky1 adonesky1 commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Removes MM_PERMISSIONS_SETTINGS_V1_ENABLED now that it only gates the SDK Connections Management view. The row is now always shown and continues to navigate to the existing SDK sessions manager.

Changelog

CHANGELOG entry: Added back access to SDK connections management.

Related issues

Fixes: WAPI-1468

Manual testing steps

Feature: Account menu permissions entry

Scenario: user opens the SDK connection manager from the account menu
Given the user is in MetaMask Mobile

When user opens the account menu
Then the Permissions row is visible

When user taps Permissions
Then the SDK connections manager opens

Screenshots/Recordings

N/A

Before

N/A

After

Screen.Recording.2026-05-04.at.3.19.31.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: removes a now-unused env flag and makes the Accounts menu Permissions row unconditional, with only minor UI/test/CI config updates.

Overview
Removes the MM_PERMISSIONS_SETTINGS_V1_ENABLED feature flag and its wiring across the app/config.

The Accounts menu now always renders the Permissions row (no gating), and related unit tests/CI env examples are updated to drop the flag.

Reviewed by Cursor Bugbot for commit d1ca060. Bugbot is set up for automated code reviews on this repo. Configure here.

@adonesky1
chore: remove permissions settings feature flag
d1ca060 
Always show the account menu permissions entry and remove the obsolete build-time flag now that it only gates that path.
@adonesky1 adonesky1 requested review from a team as code owners May 4, 2026 19:06
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-wallet-integrations Wallet Integrations team label May 4, 2026
@github-actions github-actions Bot added the size-S label May 4, 2026
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeNetworkAbstractions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 80%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR removes the MM_PERMISSIONS_SETTINGS_V1_ENABLED feature flag and makes the Permissions row in AccountsMenu always visible (previously gated behind the flag which was set to false in production builds).

Key changes:

  1. app/util/networks/index.js - Removes isPermissionsSettingsV1Enabled export
  2. app/components/Views/AccountsMenu/AccountsMenu.tsx - Permissions row is now unconditionally rendered
  3. Unit test mocks removed from AccountsMenu.test.tsx and Settings/index.test.tsx
  4. CI/build configs cleaned up (bitrise.yml, builds.yml, .js.env.example)

Impact analysis:

  • The AccountsMenu is a core component used in account management flows → SmokeAccounts
  • The Permissions row navigates to dApp permissions settings → SmokeNetworkAbstractions (chain permissions, dApp access management)
  • No E2E tests directly reference AccountsMenu permissions selectors in the smoke test suite
  • The flag was false in production, so this effectively enables the Permissions row for all users — a behavioral change that warrants validation
  • No performance-sensitive code paths are affected; this is purely a UI conditional removal

No performance tests are needed as this is a simple UI flag removal with no rendering performance implications.

Performance Test Selection:
This PR only removes a feature flag conditional around a UI element (Permissions row in AccountsMenu). There are no changes to rendering loops, data fetching, state management, or performance-critical paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adonesky1 adonesky1 changed the title Remove permissions settings feature flag chore: Remove permissions settings feature flag May 4, 2026
@adonesky1

adonesky1 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Created follow-up naming task: WAPI-1476 https://consensyssoftware.atlassian.net/browse/WAPI-1476

Scope is to align with Adam on the right account menu label (e.g. Remote Connections) and then update the copy/tests. Keeping this PR focused on removing the flag and restoring access to the existing SDK connections manager.

@adonesky1 adonesky1 added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 6684df3 May 4, 2026
191 of 198 checks passed
@adonesky1 adonesky1 deleted the wapi-1468-remove-permissions-flag branch May 4, 2026 20:53
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@weitingsun weitingsun weitingsun approved these changes

Assignees

No one assigned

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-S team-wallet-integrations Wallet Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adonesky1 @vinnyhoward @weitingsun