Skip to content

feat: TSA 488-2 Whats Happening expanded view + Explore page#29681

Merged
zone-live merged 13 commits into
mainfrom
TSA-488-2-whatshappening-expanded
May 5, 2026
Merged

feat: TSA 488-2 Whats Happening expanded view + Explore page#29681
zone-live merged 13 commits into
mainfrom
TSA-488-2-whatshappening-expanded

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the expanded view of the Whats Happening section and adds it to the Explore page.

whatshappening.mp4

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new navigation route and substantial new UI flow (carousel detail view, bottom sheet link-out, and Buy/Trade actions) which could impact navigation behavior and external URL handling if not covered by integration testing.

Overview
Adds a new Routes.WHATS_HAPPENING_DETAIL screen and wires the Homepage “What’s happening” carousel to navigate to it using only an initialIndex param (the detail view fetches its own data).

Introduces WhatsHappeningDetailView with a horizontally snapping expanded-card carousel, loading skeletons, error/retry state, and a page indicator. Expanded cards now support impact badges (new i18n strings), token/perps action rows (Buy via Ramp, Trade via Perps), and a sources bottom sheet that lists articles using a shared ArticleRow component with safe URL link-out.

Refactors Market Insights trend sources bottom sheet to reuse the new ArticleRow, and adds unit tests covering the new screen/components, navigation params, impact badge rendering, and related-asset icon resolution (getRelatedAssetImageSource).

Reviewed by Cursor Bugbot for commit c3dd999. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 4, 2026
@github-actions github-actions Bot added the size-L label May 4, 2026
@joaosantos15 joaosantos15 marked this pull request as ready for review May 4, 2026 18:34
Comment thread app/components/Views/WhatsHappeningDetailView/WhatsHappeningDetailView.tsx Outdated
@github-actions github-actions Bot added size-XL and removed size-L labels May 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit de3c4e7. Configure here.

zone-live
zone-live previously approved these changes May 5, 2026
@zone-live zone-live enabled auto-merge May 5, 2026 15:53
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new WhatsHappeningDetailView screen and related components for the Trending/Homepage feature area. Key changes:

  1. MainNavigator.js - Adds a new route WHATS_HAPPENING_DETAIL to the navigation stack. Navigation changes can affect routing for many flows, but this is an additive change (new screen only).

  2. WhatsHappeningDetailView (new) - Full-screen detail view with horizontal carousel, page indicator, expanded cards, and sources bottom sheet. This is a new feature with no existing E2E tests.

  3. WhatsHappeningSection.tsx - Updated navigation call to pass only initialIndex (not items). This changes the navigation params contract.

  4. WhatsHappeningCard.tsx - Added impact badges (Bullish/Bearish/Neutral) to the card UI.

  5. ArticleRow.tsx - New reusable component extracted from MarketInsightsTrendSourcesBottomSheet (refactor).

  6. PerpsRow.tsx - Navigates to Perps market details from the expanded card.

  7. TokenRow.tsx - Uses useRampNavigation to navigate to the Ramp buy flow.

Tag Selection Rationale:

  • SmokeWalletPlatform: The WhatsHappening section is part of the Trending tab (Homepage). Existing trending tests (trending-feed.spec.ts, trending-browser.spec.ts, trending-search.spec.ts) are all tagged SmokeWalletPlatform. The navigation change in MainNavigator and the WhatsHappeningSection navigation update need validation.
  • SmokePerps: The new PerpsRow component navigates to Perps market details. Per tag description, SmokePerps should also select SmokeWalletPlatform (already included). The Perps section is embedded in Trending.

Not selected:

  • SmokeMoney: TokenRow uses useRampNavigation but this is a new feature path (not modifying existing ramp flows). The ramp navigation hook itself is unchanged.
  • SmokeConfirmations: No direct confirmation flow changes.
  • Other tags: No relevant changes to their areas.

Performance Test Selection:
The changes are primarily UI additions for a new WhatsHappeningDetailView screen and refactoring of existing components (ArticleRow extraction). While there are new list-rendering components (carousel, article rows), these are new feature screens that don't modify existing performance-critical paths like account lists, login flows, or app startup. No performance test infrastructure changes were made. The changes don't impact the core rendering paths measured by existing performance tests.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

@zone-live zone-live added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit e8e742e May 5, 2026
93 of 94 checks passed
@zone-live zone-live deleted the TSA-488-2-whatshappening-expanded branch May 5, 2026 18:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XL team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants