fix(BETR-413): pass originalTransactionId for intent bridge history cp-7.76.0#29670
Conversation
Patch @metamask/bridge-status-controller@71.1.0 so that `originalTransactionId` is passed as a top-level argument to `getInitialHistoryItem` for intent transactions (not nested on `bridgeTxMeta`, where it is silently ignored). Without this, the bridge history record's `originalTransactionId` falls back to the orderUid, breaking the link between the bridge history entry and the synthetic TransactionController entry. As a result, Ondo (and other intent-based) swaps showed an incorrect status on the wallet activity tab. Refs: https://consensyssoftware.atlassian.net/browse/BETR-413
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62e67b3. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|




Description
Patches
@metamask/bridge-status-controller@71.1.0so that when recording intent-based bridge transactions in history,originalTransactionIdis passed as a top-level argument toaddTxToHistory.getInitialHistoryItemreads that field from the top-level args, not frombridgeTxMeta; without this, it fell back tobridgeTxMeta.id(theorderUid), which broke the link between the bridge history row and the syntheticTransactionControllerentry. That mismatch showed up in the activity tab for Ondo RWA swap flows (see BETR-413).Dependency wiring:
package.json/yarn.lockupdated to apply the Yarn patch.Changelog
CHANGELOG entry: Fixed bridge activity tab not correctly linking intent-based swaps to their underlying transaction for some bridge flows.
Related issues
Refs: BETR-413
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it changes how intent-based bridge transactions are keyed/linked between bridge history and
TransactionController, which could affect activity/status rendering for those flows.Overview
Fixes intent-based bridge history entries so they retain a stable link to the underlying synthetic transaction by passing
originalTransactionIdas a top-level argument toaddTxToHistory(instead of embedding it inbridgeTxMeta).Wires this via a Yarn patch for
@metamask/bridge-status-controller@71.1.0(updatespackage.jsonresolutions/dependency andyarn.lock) so the patcheddist/bridge-status-controllercode is used at build time.Reviewed by Cursor Bugbot for commit db8990e. Bugbot is set up for automated code reviews on this repo. Configure here.