Skip to content

test: unblock CI#29649

Merged
christopherferreira9 merged 1 commit into
mainfrom
cferreira/unblock-ci
May 4, 2026
Merged

test: unblock CI#29649
christopherferreira9 merged 1 commit into
mainfrom
cferreira/unblock-ci

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

Disables tests/smoke/predict/predict-open-position.spec.ts as it is failing consistently.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only marks a single E2E smoke spec as skipped and adds a comment; no production code paths change.

Overview
CI unblock: skips tests/smoke/predict/predict-open-position.spec.ts by switching its suite to describe.skip, with a reference link explaining the consistent failure.

Reviewed by Cursor Bugbot for commit e1111f5. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 4, 2026 12:01
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e skip E2E test jobs labels May 4, 2026
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (51b6bbd) to head (e1111f5).
⚠️ Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29649      +/-   ##
==========================================
- Coverage   82.15%   81.84%   -0.32%     
==========================================
  Files        5178     5244      +66     
  Lines      137450   138672    +1222     
  Branches    31079    31460     +381     
==========================================
+ Hits       112924   113498     +574     
- Misses      16875    17449     +574     
- Partials     7651     7725      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 9f2b444 May 4, 2026
93 of 112 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/unblock-ci branch May 4, 2026 12:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS skip-e2e skip E2E test jobs team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants