Skip to content

feat: support max money account deposit for ERC-20 tokens#29605

Merged
jpuri merged 36 commits into
mainfrom
money_acc_deposit_max
May 5, 2026
Merged

feat: support max money account deposit for ERC-20 tokens#29605
jpuri merged 36 commits into
mainfrom
money_acc_deposit_max

Conversation

@jpuri

@jpuri jpuri commented May 1, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Support for Max option in Money Account Deposit.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1290

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screenshot 2026-05-01 at 4 42 37 PM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: a small UI prop change to enable the existing CustomAmountInfo max-percentage behavior for money account deposits, plus a unit test assertion.

Overview
Money account deposit confirmations now enable the Max amount option by passing hasMax to CustomAmountInfo from MoneyAccountDepositInfo.

Adds a unit test to ensure hasMax=true is propagated alongside the existing supportAccountSelection behavior.

Reviewed by Cursor Bugbot for commit 741a489. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri jpuri requested a review from a team as a code owner May 1, 2026 11:13
@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-S label May 1, 2026
OGPoyraz
OGPoyraz previously approved these changes May 5, 2026
View reviewed changes
Base automatically changed from custom_amt_update_hook to main May 5, 2026 12:25
@jpuri jpuri dismissed OGPoyraz’s stale review May 5, 2026 12:25

The base branch was changed.

@jpuri jpuri requested a review from a team as a code owner May 5, 2026 12:25
@jpuri jpuri requested a review from OGPoyraz May 5, 2026 12:27
@jpuri jpuri enabled auto-merge May 5, 2026 12:27
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are minimal and focused: adding hasMax prop to CustomAmountInfo in MoneyAccountDepositInfo component, which changes the deposit keyboard UI to show a "Max" button instead of a "90%" button. A corresponding unit test is also added.

Impact:

  • MoneyAccountDepositInfo is used in the confirmation info-root for money account deposit flows (MetaMask Card/fiat deposit)
  • The hasMax prop is already used in similar components (perps-deposit-info, money-account-withdraw-info, musd-conversion-info), so this is a consistent pattern
  • The change is purely UI/UX (button label change in deposit keyboard)

Tag Selection:

  • SmokeMoney: Directly covers MetaMask Card and fiat deposit flows where this component is used
  • SmokeConfirmations: Per tag guidance, when selecting SmokeMoney for Card Add Funds flows, also select SmokeConfirmations since deposit flows go through the confirmation system

Performance Tests: No performance impact expected from this small UI prop addition (just changes a button label from "90%" to "Max").

Performance Test Selection:
The change is a minor UI prop addition (hasMax=true) that only affects a button label in the deposit keyboard. No performance impact expected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 3751b07 May 5, 2026
96 checks passed
@jpuri jpuri deleted the money_acc_deposit_max branch May 5, 2026 13:22
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpuri @OGPoyraz