Description

Inline [] fallbacks in useWithdrawalRequests selectors were creating new array references on every render, triggering React-Redux's "Selector unknown returned a different result" warning and causing unnecessary re-renders in PerpsProgressBar on mount.

Fixed by replacing inline [] literals with module-level constants and short-circuiting .filter() on empty arrays so selectors always return the same reference.

Performance impact: FPS on Perps tab mount improved from 60→22 drops down to a stable 60→57, nearly eliminating the frame drop entirely and it doesn't take ~1 second for the Perps screen to show anymore

NOTE: Unrelated to these changes, there is a considerate amount of frame drop when you're on the Perps home screen and from the UI hydrating. The frames drop as low as 8 FPS. This happens in main and this branch as well. Might be worth a follow up ticket

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: Perps home screen mount

  Scenario: user opens the app with Perps hub tab visible
    Given the hub tabs A/B test is enabled
    And the user has no pending withdrawal requests

    When the app loads and PerpsProgressBar mounts
    Then no "Selector unknown returned a different result" warning appears in the console
    And the Perps tab renders without unnecessary re-renders
    And FPS remains at or above 57 during mount

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.