chore: Update main-dev for expo and release build configurations by Cal-L · Pull Request #29572 · MetaMask/metamask-mobile

Cal-L · 2026-04-30T17:06:28Z

Description

This PR updates build variants:

Create main-dev-expo for producing Expo debug dev builds (.app, .ipa, .apk, test .apk)
Update main-dev for producing release dev builds for installation via side loading

Slack thread - https://consensys.slack.com/archives/C02U025CVU4/p1776795191936139

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-561

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it changes CI build selection and iOS signing/export behavior (including overriding signing settings for Release archives), which could break artifact generation or produce incorrectly signed builds.

Overview
Separates dev build configurations by introducing main-dev-expo (Debug Expo dev builds that produce simulator + device iOS artifacts and Android APK + test APK) while repurposing main-dev as a dev release build intended for sideloading.

Updates the reusable build.yml workflow to support an optional script_name override from builds.yml, so different build configs can reuse the same underlying yarn build script. Adjusts scripts/build.sh iOS packaging to use a new PROFILE flag for selecting export options and to allow development signing overrides when creating a Release archive.

^{Reviewed by Cursor Bugbot for commit dc86270. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-04-30T17:06:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor · 2026-04-30T21:04:01Z

-	else
+	fi
+
+	if [ "$IS_DEVICE_BUILD" = "true" ] || [ -z "$IS_SIM_BUILD" ]; then


Device build fallback condition narrower than original

Low Severity

The device build fallback changed from an else (triggered for any IS_SIM_BUILD value that isn't "true") to [ -z "$IS_SIM_BUILD" ] (triggered only when IS_SIM_BUILD is empty/unset). If IS_SIM_BUILD is ever set to a non-empty value other than "true" (e.g. "false"), and IS_DEVICE_BUILD is also not "true", the new code produces no iOS build at all — neither simulator nor device. The old code would correctly fall through to a device build via the else branch. Using [ "$IS_SIM_BUILD" != "true" ] instead of [ -z "$IS_SIM_BUILD" ] would preserve the original semantics.

^{Reviewed by Cursor Bugbot for commit 8690d5d. Configure here.}

github-actions · 2026-05-01T17:38:39Z

🔍 Smart E2E Test Selection

Selected E2E tags: None (no tests recommended)
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 4 changed files are CI/build infrastructure files with no impact on application source code, E2E test logic, or test infrastructure:

.github/workflows/build.yml: Adds main-dev-expo as a valid build name and introduces a script_name output to allow builds.yml to override the yarn script name used during builds. This is purely a CI pipeline change.
.github/workflows/expo-dev-build.yml: Renames the Expo dev build from main-dev to main-dev-expo to use the new dedicated configuration. No test execution changes.
builds.yml: Refactors the main-dev build into a proper dev release build (for sideloading), adds a new main-dev-expo build config with script_name: main-dev override, and adds PROFILE: 'development' env var. These are build configuration changes only.
scripts/build.sh: Refactors iOS binary generation to use a PROFILE env var instead of configuration to select export options plist, separates simulator and device build steps, and adds signing override support for Release archives with development profile. This is a build script change with no runtime app code impact.

None of these changes affect:

Application source code or runtime behavior
E2E test files, fixtures, or page objects
Test framework infrastructure
Any user-facing features or flows

Since these are purely build/CI infrastructure changes that don't affect the app's behavior or test infrastructure, no E2E test tags need to be run.

Performance Test Selection:
No performance-sensitive code was changed. All modifications are to CI/build infrastructure (GitHub Actions workflows, build configuration YAML, and build shell script). These changes have no impact on app rendering, data loading, state management, or any other performance-sensitive areas.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit dc86270. Configure here.}

sonarqubecloud · 2026-05-01T17:53:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Create main-dev-expo build variant

0061477

Cal-L requested a review from a team as a code owner April 30, 2026 17:06

metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label Apr 30, 2026

github-project-automation Bot added this to PR review queue Apr 30, 2026

github-project-automation Bot moved this to Needs dev review in PR review queue Apr 30, 2026

github-actions Bot added the size-S label Apr 30, 2026

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread builds.yml

Cal-L had a problem deploying to build-dev April 30, 2026 17:25 — with GitHub Actions Error

Cal-L had a problem deploying to build-dev April 30, 2026 17:25 — with GitHub Actions Failure

Cal-L had a problem deploying to build-dev April 30, 2026 17:27 — with GitHub Actions Error

Cal-L had a problem deploying to build-dev April 30, 2026 17:27 — with GitHub Actions Failure

Cal-L added 2 commits April 30, 2026 11:09

Add script_name to override script

43dad8e

Specify development profile

8690d5d

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Cal-L had a problem deploying to build-dev April 30, 2026 21:55 — with GitHub Actions Error

Cal-L had a problem deploying to build-dev April 30, 2026 21:55 — with GitHub Actions Failure

Cal-L temporarily deployed to build-dev April 30, 2026 21:55 — with GitHub Actions Inactive

Override archive for release dev build

d37c900

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread scripts/build.sh Outdated

Cal-L temporarily deployed to build-dev April 30, 2026 22:47 — with GitHub Actions Inactive

Cal-L had a problem deploying to build-production April 30, 2026 23:22 — with GitHub Actions Failure

Cal-L had a problem deploying to build-dev April 30, 2026 23:31 — with GitHub Actions Failure

Fix profile var name

44e2457

Cal-L had a problem deploying to build-dev May 1, 2026 08:53 — with GitHub Actions Failure

Override code sign identity for development

37e4bf3

cursor Bot reviewed May 1, 2026

View reviewed changes

Comment thread scripts/build.sh Outdated

Cal-L had a problem deploying to build-dev May 1, 2026 16:49 — with GitHub Actions Failure

Prvent shell word splits

dc86270

cursor Bot reviewed May 1, 2026

View reviewed changes

Comment thread scripts/build.sh

Cal-L temporarily deployed to build-dev May 1, 2026 17:45 — with GitHub Actions Inactive

Cal-L temporarily deployed to build-dev May 1, 2026 18:51 — with GitHub Actions Inactive

Cal-L enabled auto-merge May 1, 2026 21:18

weitingsun approved these changes May 1, 2026

View reviewed changes

Cal-L added this pull request to the merge queue May 1, 2026

github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 1, 2026

Merged via the queue into main with commit 9b73aff May 1, 2026
75 of 78 checks passed

Cal-L deleted the chore/MCWP-561-main-dev-release branch May 1, 2026 21:37

github-actions Bot locked and limited conversation to collaborators May 1, 2026

github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 1, 2026

metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Update main-dev for expo and release build configurations#29572

chore: Update main-dev for expo and release build configurations#29572
Cal-L merged 7 commits into
mainfrom
chore/MCWP-561-main-dev-release

Cal-L commented Apr 30, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

cursor Bot Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Cal-L commented Apr 30, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

cursor Bot Apr 30, 2026

Choose a reason for hiding this comment

Device build fallback condition narrower than original

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 1, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Cal-L commented Apr 30, 2026 •

edited by cursor Bot

Loading