Skip to content

ci: skip E2E for locale translation changes#29565

Merged
Qbandev merged 1 commit into
mainfrom
mcwp-440-locales-e2e-ignorable
Apr 30, 2026
Merged

ci: skip E2E for locale translation changes#29565
Qbandev merged 1 commit into
mainfrom
mcwp-440-locales-e2e-ignorable

Conversation

@Qbandev

@Qbandev Qbandev commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR updates the post-#29305 CI requirement filters so locale translation JSON changes are treated as E2E-ignorable.

Locale-only PRs under locales/languages/**/*.json should now skip Smart E2E selection plus Android/iOS E2E builds and smoke tests. The change also adds the same locale rule to the Android/iOS platform-or-ignorable filters, so mixed platform + locale changes keep platform-specific E2E behavior instead of expanding to both platforms.

Changelog

CHANGELOG entry: null

Related issues

Fixes: MCWP-440

Manual testing steps

Feature: CI requirements for locale translation changes

  Scenario: locale translation PR skips E2E
    Given a pull request changes only files under locales/languages/**/*.json
    When the ci workflow runs get-requirements
    Then Smart E2E selection is skipped
    And Android E2E build and smoke test jobs are skipped
    And iOS E2E build and smoke test jobs are skipped
    And pr-not-ready-for-e2e does not block merge for the ignorable-only change

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Qbandev Qbandev self-assigned this Apr 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-dev-ops DevOps team label Apr 30, 2026
@Qbandev Qbandev added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 30, 2026
@Qbandev Qbandev force-pushed the mcwp-440-locales-e2e-ignorable branch from 53990c3 to 14e1bf0 Compare April 30, 2026 14:30
@github-actions github-actions Bot added size-XS and removed size-S labels Apr 30, 2026
@Qbandev Qbandev marked this pull request as ready for review April 30, 2026 14:34
@Qbandev Qbandev requested a review from a team as a code owner April 30, 2026 14:34
@sonarqubecloud

Copy link
Copy Markdown

@Qbandev Qbandev added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 30, 2026
@Qbandev Qbandev enabled auto-merge April 30, 2026 16:03

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qbandev Qbandev added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 6e2fa57 Apr 30, 2026
67 checks passed
@Qbandev Qbandev deleted the mcwp-440-locales-e2e-ignorable branch April 30, 2026 21:12
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants