Skip to content

chore(runway): cherry-pick fix(confirmations): prevent Perps withdraw clipping on Android#29555

Merged
joaoloureirop merged 1 commit into
release/7.75.0from
cherry-pick-7-75-0-edaf5b3
Apr 30, 2026
Merged

chore(runway): cherry-pick fix(confirmations): prevent Perps withdraw clipping on Android#29555
joaoloureirop merged 1 commit into
release/7.75.0from
cherry-pick-7-75-0-edaf5b3

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes an Android layout issue where the Perps Withdraw confirmation
keypad bottom row and the final Withdraw button could be clipped behind
the system navigation area.

The fix keeps the shared full-screen confirmation layout intact, ensures
the confirmation ScrollView fills its safe-area container, and applies
extra Android bottom spacing only to the Perps Withdraw bottom block.

Changelog

CHANGELOG entry: Fixed Perps Withdraw on Android so the keypad and
Withdraw button remain fully visible.

Related issues

Fixes: #29363

Manual testing steps

Feature: Perps Withdraw Android layout

  Scenario: Perps Withdraw keypad is fully visible on Android
    Given I am on the Perps Withdraw confirmation
    When the amount keyboard is visible
Then the bottom keypad row is fully visible above the Android navigation
bar

  Scenario: Perps Withdraw button is fully visible on Android
    Given I am on the Perps Withdraw confirmation
    When I enter an amount and continue past the keyboard
    Then the Withdraw button is fully visible with bottom spacing

  Scenario: Other deposit flows are not regressed
    Given I open Perps Deposit and Predict Deposit confirmations
Then their keyboards remain fully visible and keep expected bottom
spacing

Screenshots/Recordings

Before

Android Perps Withdraw keypad / Withdraw button clipped behind the
system navigation area.

After

Android Perps Withdraw keypad and Withdraw button fully visible.
Verified on Pixel 6 and Pixel 10 Pro XL.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Small, opt-in styling change scoped to Perps Withdraw (and
Android-only) with added unit tests; minimal risk beyond potential minor
layout spacing differences on affected screens.

Overview
Prevents Perps Withdraw confirmation UI from clipping behind the
Android gesture/navigation bar by adding an opt-in
hasExtraBottomPadding prop to CustomAmountInfo and applying a 56dp
paddingBottom to the bottom block only on Android.

PerpsWithdrawInfo now enables this padding, and new test IDs plus
unit tests cover the platform-conditional styling and prop behavior to
avoid iOS/layout regressions.

Reviewed by Cursor Bugbot for commit
dd5c508. Bugbot is set up for automated
code reviews on this repo. Configure
here.


Signed-off-by: dan437 80175477+dan437@users.noreply.github.com edaf5b3

…5.0 (#29434)

Fixes an Android layout issue where the Perps Withdraw confirmation
keypad bottom row and the final Withdraw button could be clipped behind
the system navigation area.

The fix keeps the shared full-screen confirmation layout intact, ensures
the confirmation ScrollView fills its safe-area container, and applies
extra Android bottom spacing only to the Perps Withdraw bottom block.

CHANGELOG entry: Fixed Perps Withdraw on Android so the keypad and
Withdraw button remain fully visible.

Fixes: #29363

~~~gherkin
Feature: Perps Withdraw Android layout

  Scenario: Perps Withdraw keypad is fully visible on Android
    Given I am on the Perps Withdraw confirmation
    When the amount keyboard is visible
Then the bottom keypad row is fully visible above the Android navigation
bar

  Scenario: Perps Withdraw button is fully visible on Android
    Given I am on the Perps Withdraw confirmation
    When I enter an amount and continue past the keyboard
    Then the Withdraw button is fully visible with bottom spacing

  Scenario: Other deposit flows are not regressed
    Given I open Perps Deposit and Predict Deposit confirmations
Then their keyboards remain fully visible and keep expected bottom
spacing
~~~

Android Perps Withdraw keypad / Withdraw button clipped behind the
system navigation area.

Android Perps Withdraw keypad and Withdraw button fully visible.
Verified on Pixel 6 and Pixel 10 Pro XL.

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [x] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [x] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Small, opt-in styling change scoped to Perps Withdraw (and
Android-only) with added unit tests; minimal risk beyond potential minor
layout spacing differences on affected screens.
>
> **Overview**
> Prevents Perps Withdraw confirmation UI from clipping behind the
Android gesture/navigation bar by adding an opt-in
`hasExtraBottomPadding` prop to `CustomAmountInfo` and applying a 56dp
`paddingBottom` to the bottom block *only on Android*.
>
> `PerpsWithdrawInfo` now enables this padding, and new test IDs plus
unit tests cover the platform-conditional styling and prop behavior to
avoid iOS/layout regressions.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
dd5c508. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@runway-github runway-github Bot requested a review from a team as a code owner April 30, 2026 10:38
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@joaoloureirop joaoloureirop enabled auto-merge (squash) April 30, 2026 10:42
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@joaoloureirop joaoloureirop merged commit 7bf3f76 into release/7.75.0 Apr 30, 2026
113 checks passed
@joaoloureirop joaoloureirop deleted the cherry-pick-7-75-0-edaf5b3 branch April 30, 2026 11:38
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants