ci: improve E2E merge gate, add yarn cache, rename flakiness label by jvbriones · Pull Request #29553 · MetaMask/metamask-mobile

jvbriones · 2026-04-30T10:33:56Z

Description

Three independent improvements to the CI pipeline:

E2E merge gate fix: Gate now checks build jobs too (build-android-apks, build-ios-apps). Previously a failed build caused smoke tests to skip, which the gate treated as passing. This will avoid PRs getting merged with broken builds like: https://github.com/MetaMask/metamask-mobile/actions/runs/25074016847
Yarn cache: Added node_modules + .yarn/install-state.gz caching to component-view-tests, merge-unit-and-component-view-tests, and setup-e2e-env. Saves ~2–4 min on cache hits.
Label rename: skip-e2e-quality-gate → skip-e2e-flakiness-detection. Post-merge: rename the label manually in GitHub repo settings.
Time-gated auto-labeling: The pr-not-ready-for-e2e label is now only auto-applied to new PRs opened between 13:00–17:00 UTC (15:00–19:00 CEST / 9:00–13:00 EDT), targeting the Europe–US East Coast overlap window.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Modifies CI workflow gating and label-driven behavior that can block or permit merges, so misconfiguration could affect release throughput. Changes are scoped to GitHub Actions/scripts and caching, with no app runtime impact.

Overview
CI merge gating is tightened for E2E by treating failures/cancellations in build-android-apks and build-ios-apps as merge-blocking (previously a failed build could cause smoke tests to skip and still pass the gate), while still allowing intentional skipped outcomes when E2E is not expected to run.

Dependency caching is expanded by caching node_modules plus .yarn/install-state.gz in the shared setup-e2e-env action and in ci.yml jobs that run component-view tests and coverage merge, skipping yarn install on cache hits.

Labeling/controls are updated: skip-e2e-quality-gate is renamed to skip-e2e-flakiness-detection across scripts, rerun triggers, and docs; auto-label-not-ready-for-e2e is time-gated (13:00–17:00 UTC) before applying pr-not-ready-for-e2e; and documentation/ownership is updated (adds QA ownership for E2E_DECISION_TREE.md and clarifies skip-e2e as an exceptional “skip builds + all E2E” escape hatch).

^{Reviewed by Cursor Bugbot for commit ede188d. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-04-30T10:34:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 85a1ea8. Configure here.}

github-actions · 2026-04-30T15:29:30Z

🔍 Smart E2E Test Selection

Selected E2E tags: None (no tests recommended)
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 8 changed files are CI infrastructure, documentation, and configuration files with no application code changes:

.github/actions/setup-e2e-env/action.yml: Adds .yarn/install-state.gz to the yarn cache path — a CI cache optimization that doesn't affect app behavior or test logic.
.github/workflows/ci.yml: Two improvements — (a) adds node_modules cache restoration to speed up CI jobs, and (b) expands the all-jobs-pass gate to also check build-android-apks and build-ios-apps results. These are CI pipeline reliability improvements, not app changes.
.github/workflows/auto-label-not-ready-for-e2e.yml: Adds a time-window check (13:00–17:00 UTC) for auto-applying the pr-not-ready-for-e2e label. Pure workflow logic change.
.github/workflows/rerun-ci-on-skipped-e2e-labels.yml: Renames label skip-e2e-quality-gate → skip-e2e-flakiness-detection and adds error handling for the rerun command.
.github/scripts/e2e-split-tags-shards.mjs: Updates the label name check to match the renamed label — consistent with the workflow change.
.github/guidelines/E2E_DECISION_TREE.md and .github/guidelines/LABELING_GUIDELINES.md: Documentation updates reflecting the label rename and new guidance.
.github/CODEOWNERS: Adds E2E_DECISION_TREE.md to QA team ownership.

None of these changes touch application source code, E2E test files, test page objects, fixtures, or any component that would require Detox E2E validation. The CI workflow changes are validated by GitHub Actions itself when the workflows run, not by Detox tests. No performance-sensitive code is modified either.

Performance Test Selection:
No application code, UI components, state management, or performance-sensitive paths were modified. All changes are CI infrastructure, workflow configuration, documentation, and label renaming. No performance tests are warranted.

View GitHub Actions results

sonarqubecloud · 2026-04-30T15:44:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ci: rename e2e quality gate PR label

7d983d2

jvbriones requested a review from a team as a code owner April 30, 2026 10:33

metamaskbotv2 Bot added the team-qa QA team label Apr 30, 2026

github-actions Bot added the size-XS label Apr 30, 2026

ci: rename e2e quality gate PR label

0ff0fd7

jvbriones added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. and removed skip-e2e skip E2E test jobs labels Apr 30, 2026

ci: rename e2e quality gate PR label

f52496c

github-actions Bot added size-S and removed size-XS labels Apr 30, 2026

jvbriones added skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Apr 30, 2026

ci: rename e2e quality gate PR label

aa2924e

jvbriones requested a review from a team as a code owner April 30, 2026 14:34

Merge remote-tracking branch 'origin' into test-e2e-readiness-label-1

f44f1a1

jvbriones changed the title ~~ci: rename e2e quality gate PR label~~ ci: improve E2E merge gate, add yarn cache, rename flakiness label Apr 30, 2026

ci: rename e2e quality gate PR label

b2b6301

jvbriones removed the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Apr 30, 2026

ci: rename e2e quality gate PR label

85a1ea8

cursor Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread .github/workflows/rerun-ci-on-skipped-e2e-labels.yml Outdated

ci: rename e2e quality gate PR label

ede188d

jvbriones enabled auto-merge April 30, 2026 16:06

racitores approved these changes Apr 30, 2026

View reviewed changes

weitingsun approved these changes Apr 30, 2026

View reviewed changes

jvbriones added this pull request to the merge queue Apr 30, 2026

Merged via the queue into main with commit 84250b3 Apr 30, 2026
61 checks passed

jvbriones deleted the test-e2e-readiness-label-1 branch April 30, 2026 19:37

github-actions Bot locked and limited conversation to collaborators Apr 30, 2026

metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: improve E2E merge gate, add yarn cache, rename flakiness label#29553

ci: improve E2E merge gate, add yarn cache, rename flakiness label#29553
jvbriones merged 8 commits into
mainfrom
test-e2e-readiness-label-1

jvbriones commented Apr 30, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

sonarqubecloud Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jvbriones commented Apr 30, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jvbriones commented Apr 30, 2026 •

edited by cursor Bot

Loading