Skip to content

fix: show collection name in nft details#29551

Merged
Prithpal-Sooriya merged 1 commit into
mainfrom
cursor/nft-details-collection-name-8b37
May 7, 2026
Merged

fix: show collection name in nft details#29551
Prithpal-Sooriya merged 1 commit into
mainfrom
cursor/nft-details-collection-name-8b37

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the missing collection name field to the NFT details screen. The data already existed on collectible.collection.name, but the screen did not render it.

Changelog

CHANGELOG entry: fix: NFT details did not show the collection name

Related issues

Fixes: #29362 https://consensyssoftware.atlassian.net/browse/ASSETS-3125

Manual testing steps

Feature: NFT details collection metadata

  Scenario: User views an NFT details page
    Given the user has imported NFTs from a collection
    When user opens the details screen for one NFT
    Then the screen displays the collection name in the Collection section

Screenshots/Recordings

Before

After

Screenshot 2026-05-07 at 10 49 53

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics
Open in Web Open in Cursor 

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are minimal and isolated: (1) NftDetails.tsx adds a single new NftDetailsInformationRow to display the NFT collection name (collectible.collection?.name) — a purely additive UI change with no impact on navigation, shared components, controllers, or other flows; (2) NftDetails.test.ts adds a corresponding unit test assertion. No E2E test tags cover NFT details functionality. The change cannot break any existing E2E flows as it only adds a new display row in an isolated detail view. No controller, Engine, or shared component is touched.

Performance Test Selection:
The change adds a single text row to the NFT Details screen. This has negligible performance impact — no list rendering changes, no new data fetching, no state management changes, and no impact on critical user flows measured by performance tests.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review May 7, 2026 09:51
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner May 7, 2026 09:51

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 386235d. Configure here.

Comment thread app/components/Views/NftDetails/NftDetails.tsx
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit e0d7d70 May 7, 2026
92 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the cursor/nft-details-collection-name-8b37 branch May 7, 2026 10:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Assets - NFT details don't display Collection name

3 participants