Skip to content

feat: added developer options button to clear dismissed mUSD conversion asset details CTAs#29510

Merged
Matt561 merged 4 commits into
mainfrom
feat/reset-dismissed-tertiary-musd-conversion-cta-state-in-developer-settings
Apr 29, 2026
Merged

feat: added developer options button to clear dismissed mUSD conversion asset details CTAs#29510
Matt561 merged 4 commits into
mainfrom
feat/reset-dismissed-tertiary-musd-conversion-cta-state-in-developer-settings

Conversation

@Matt561

@Matt561 Matt561 commented Apr 29, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Added developer options button to clear dismissed mUSD conversion asset details CTAs. This allows easy resetting of this user state without reinstalling the app.

The mUSD conversion CTA displayed on the asset details screen does not reappear after the user dismisses it.

Changelog

CHANGELOG entry: added developer options button to clear dismissed mUSD conversion asset details CTAs.

Related issues

Fixes:

Manual testing steps

Feature: Reset dismissed mUSD asset detail screen CTAs (tertiary CTA)

  Scenario: internal user resets dismissed mUSD asset details screen CTAs
    Given user has already dismissed CTA on asset details screen for support asset (e.g. mainnet USDC)

    When user click the reset button in the developer options menu
    Then the CTA reappear on the asset details screen

Screenshots/Recordings

Before

After

musd-727-clearing-dismissed-ctas-state-demo-after.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Developer-options-only state reset of a single user preference map; minimal surface area and covered by unit tests.

Overview
Adds a new Redux action (CLEAR_MUSD_CONVERSION_ASSET_DETAIL_CTAS_SEEN) and action creator (clearMusdConversionAssetDetailCtasSeen) to wipe persisted mUSD asset-detail CTA dismissal state.

Updates the user reducer to handle this action by resetting musdConversionAssetDetailCtasSeen to {}, and extends the mUSD developer options UI to show the current dismissed count and provide a button to clear it, with expanded unit tests covering rendering and dispatch behavior.

Reviewed by Cursor Bugbot for commit bf99c87. Bugbot is set up for automated code reviews on this repo. Configure here.

@Matt561 Matt561 requested a review from a team as a code owner April 29, 2026 17:32
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Apr 29, 2026
@github-actions github-actions Bot added size-M and removed size-S labels Apr 29, 2026
cursor[bot]
cursor Bot reviewed Apr 29, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 376130f. Configure here.

Comment thread app/components/UI/Earn/components/MusdDeveloperOptionsSection.tsx Outdated
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are narrowly scoped to the Earn/mUSD feature area:

  1. New Redux action type (CLEAR_MUSD_CONVERSION_ASSET_DETAIL_CTAS_SEEN) - purely additive, no modification of existing action types or reducer cases
  2. New action creator (clearMusdConversionAssetDetailCtasSeen) - additive only
  3. New reducer case - resets musdConversionAssetDetailCtasSeen to {}, additive and isolated
  4. MusdDeveloperOptionsSection.tsx - Developer options UI component for the Earn/mUSD feature, adds a button to clear CTA dismissal state for testing purposes
  5. MusdDeveloperOptionsSection.test.tsx - Unit tests for the above

These changes are entirely within the Earn feature's developer options section. The mUSD (MetaMask USD stablecoin) feature is part of the Earn/staking functionality, which falls under SmokeTrade (DeFi trading and financial features). No shared components, navigation, confirmations, or core infrastructure are affected. The changes are additive and low-risk.

SmokeTrade is selected as the most relevant tag since Earn/staking features are accessed via the Trade wallet actions menu. No other tags are warranted as the changes don't touch confirmations flows, account management, network management, or any other feature areas.

Performance Test Selection:
The changes are limited to a developer options UI component and Redux action/reducer additions for the mUSD Earn feature. No performance-sensitive code paths are affected - no list rendering, no data loading hooks, no app initialization, no critical user flows. The changes are purely additive developer tooling.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Apr 29, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@Matt561 Matt561 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit cff2ccf Apr 29, 2026
91 of 92 checks passed
@Matt561 Matt561 deleted the feat/reset-dismissed-tertiary-musd-conversion-cta-state-in-developer-settings branch April 29, 2026 22:11
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@shane-t shane-t shane-t approved these changes

Assignees

No one assigned

Labels

release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-earn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matt561 @shane-t