Skip to content

fix: fixed lending empty state rendering for unsupported asset like Linea DAI cp-7.75.0#29508

Merged
Matt561 merged 1 commit into
mainfrom
fix/linea-dai-lending-empty-state-should-not-be-rendered
Apr 29, 2026
Merged

fix: fixed lending empty state rendering for unsupported asset like Linea DAI cp-7.75.0#29508
Matt561 merged 1 commit into
mainfrom
fix/linea-dai-lending-empty-state-should-not-be-rendered

Conversation

@Matt561

@Matt561 Matt561 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes a bug where the stablecoin lending empty state CTA was rendered for assets that weren't supported but were supported for the mUSD conversion feature.

Changelog

CHANGELOG entry: fixed bug where the stablecoin lending empty state CTA was rendered for assets that weren't supported but were supported for the mUSD conversion feature.

Related issues

Fixes:

Manual testing steps

Feature: Stablecoin Lending Empty State CTA rendering behaviour

  Scenario: user does not see the stablecoin lending empty state CTA rendered
    Given user has Linea DAI balance > $0.01

    When user navigates to Linea DAI asset details screen
    And user dismisses the mUSD conversion CTA banner
    Then user does not see the stablecoin lending empty state CTA

Screenshots/Recordings

Before

After

release-blocker-29504-demo-after.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI-logic change that only tightens CTA rendering conditions; low chance of side effects beyond Earn CTA visibility.

Overview
Fixes an Earn asset-details UI bug where the stablecoin lending empty state CTA could appear for unsupported assets.

EarnLendingBalance now renders EarnEmptyStateCta only when the token is part of the STABLECOIN_LENDING experience (in addition to the existing checks for not being a receipt token and having no lending positions), while still prioritizing the mUSD conversion CTA when applicable.

Reviewed by Cursor Bugbot for commit 701ba31. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@Matt561 Matt561 enabled auto-merge April 29, 2026 17:32
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@Matt561 Matt561 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit a52bfa4 Apr 29, 2026
138 checks passed
@Matt561 Matt561 deleted the fix/linea-dai-lending-empty-state-should-not-be-rendered branch April 29, 2026 18:15
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-XS team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants