Skip to content

test: e2e labels rename and shards update#29431

Merged
racitores merged 4 commits into
mainfrom
raci/add-shards
Apr 30, 2026
Merged

test: e2e labels rename and shards update#29431
racitores merged 4 commits into
mainfrom
raci/add-shards

Conversation

@racitores

@racitores racitores commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

Refactors E2E smoke tagging to better match feature ownership and test scope, and updates all downstream consumers (specs, workflows, Bitrise, analyzer/docs).

Main changes:

  • Replaced SmokeTrade with:
    • SmokeSwap for tests/smoke/swap/*
    • SmokeStake for tests/smoke/stake/*
  • Merged Card + Ramps under SmokeMoney:
    • Updated tests/smoke/card/* and tests/smoke/ramps/*
    • Removed deprecated SmokeCard and SmokeRamps
  • Merged Seedless onboarding under SmokeAccounts:
    • Updated tests/smoke/seedless/*
    • Removed deprecated SmokeSeedlessOnboarding
  • Added one extra Snap shard in smoke workflows:
    • iOS: snaps-ios-smoke 3 -> 4
    • Android: snaps-android-smoke 3 -> 4

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Smoke tag taxonomy migration

  Scenario: run smoke workflows with new tags
    Given a branch with the updated smoke tags and workflow config
    When smoke workflows are triggered for iOS and Android
    Then tests in swap use SmokeSwap
    And tests in stake use SmokeStake
    And tests in card and ramps use SmokeMoney
    And tests in seedless use SmokeAccounts

  Scenario: verify deprecated tags are removed
    Given the updated repository
    When searching for SmokeTrade, SmokeCard, SmokeRamps, and SmokeSeedlessOnboarding
    Then no active smoke spec or smoke workflow references those tags

Screenshots/Recordings

Before

N/A (tag/workflow refactor)

After

N/A (tag/workflow refactor)

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@racitores racitores added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@racitores racitores added the team-qa QA team label Apr 28, 2026
@racitores racitores marked this pull request as ready for review April 29, 2026 11:30
@racitores racitores requested review from a team as code owners April 29, 2026 11:30
@racitores racitores added skip-e2e-flakiness-detection Skips the E2E flakiness detection (extra runs on new and modified E2E files) labels Apr 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSwap, SmokeStake, SmokeMoney, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR is a pure E2E test infrastructure refactoring — no app code was changed. The changes are:

  1. Tag renaming in tests/tags.js: SmokeTrade → split into SmokeSwap (swap/bridge tests) and SmokeStake (stake/lending tests); SmokeCard + SmokeRamps → merged into SmokeMoney (card + fiat ramps).

  2. All spec files updated: Every test in tests/smoke/swap/, tests/smoke/stake/, tests/smoke/card/, and tests/smoke/ramps/ had their describe() tag updated from the old tag to the new tag.

  3. CI workflows updated: Both Android and iOS smoke test workflows now have new job names (swap-android-smoke, stake-android-smoke, money-android-smoke) with correct tag conditions. SmokeSnaps also expanded from 3 to 4 splits.

  4. Documentation/tooling updated: AI analyzer handlers.ts, skill files, and agent SKILL.md all updated to reference new tag names.

Why these tags: The renamed tests must be run to validate the tag renaming works correctly end-to-end — that the CI correctly picks up tests with the new tag names and routes them to the right jobs. Running SmokeSwap, SmokeStake, and SmokeMoney validates all three renamed tag groups. SmokeConfirmations is included as a dependent tag per the descriptions of SmokeSwap and SmokeStake (transaction confirmations are part of swap and stake flows).

No performance impact: These are purely test infrastructure changes with no app code modifications, so no performance tests are needed.

Performance Test Selection:
This PR contains only E2E test infrastructure changes (tag renaming, CI workflow updates, documentation). No app code was modified, so there is no performance impact to measure.

View GitHub Actions results

@metamaskbotv2 metamaskbotv2 Bot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 29, 2026
@racitores racitores enabled auto-merge April 29, 2026 13:48
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@racitores racitores added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 2559cc5 Apr 30, 2026
211 of 246 checks passed
@racitores racitores deleted the raci/add-shards branch April 30, 2026 12:16
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-M skip-e2e-flakiness-detection Skips the E2E flakiness detection (extra runs on new and modified E2E files) team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants