Skip to content

feat: MUSD-691 clean up deprecated quick convert code#29351

Merged
Matt561 merged 14 commits into
mainfrom
feat/musd-691-clean-up-deprecated-quick-convert-code
May 1, 2026
Merged

feat: MUSD-691 clean up deprecated quick convert code#29351
Matt561 merged 14 commits into
mainfrom
feat/musd-691-clean-up-deprecated-quick-convert-code

Conversation

@Matt561

@Matt561 Matt561 commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR removes the now deprecated Quick Convert code paths. We're keeping the Max convert bottom sheet and the MusdConversionAssetRow components to integrate into the Money Home screen.

Changelog

CHANGELOG entry: remove deprecated quick convert feature code paths

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it removes a navigation route/feature flag and rewires mUSD conversion CTAs and analytics to always use the custom-amount flow, which could affect user routing and event reporting if any remaining callers expected Quick Convert.

Overview
Removes the deprecated mUSD Quick Convert flow end-to-end: deletes MusdQuickConvertView (and MusdBalanceCard), drops the MM_MUSD_QUICK_CONVERT_ENABLED env var, removes the quick-convert feature-flag selector/remote registry entries, and removes the Routes.EARN.MUSD.QUICK_CONVERT route.

Updates mUSD conversion entry points (useMusdConversion, education screen, cash/token list/asset CTAs) to stop passing/handling navigationOverride and to always route/track redirects to CUSTOM_AMOUNT_SCREEN (while keeping the max-convert bottom sheet location constant).

Renames ConvertTokenRow to MusdConversionAssetRow and updates downstream usage/tests (e.g., Money convert stablecoins, cash tokens skeleton) to use the new component/test IDs.

Reviewed by Cursor Bugbot for commit 74947e7. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Matt561 added 13 commits May 1, 2026 16:20
@Matt561
chore: removed quick convert route from Earn navigation stack
d4a3532
@Matt561
chore: remove navigateToQuickConvert function from useMusdConversion
287c28c
@Matt561
chore: remove usage of selectMusdQuickConvertEnabledFlag from useMusd…
89ed243 
…Conversion
@Matt561
chore: remove MusdBalanceCard component and references
16a9e41
@Matt561
chore: delete MusdQuickConvertView
97f19d6
@Matt561
chore: removed MM_MUSD_QUICK_CONVERT_ENABLED flag
a296e77
@Matt561
chore: removed selectMusdQuickConvertEnabledFlag selector
0c8dfc8
@Matt561
chore: removed QUICK_CONVERT_HOME_SCREEN from musd event locations co…
188bbad 
…nstant
@Matt561
chore: removed QUICK_CONVERT_SCREEN_VIEWED event
dc46270
@Matt561
chore: removed calls to selectMusdQuickConvertEnabledFlag
4871496
@Matt561
chore: renamed ConvertTokenRow to MusdConversionAssetRow
9fadc52
@Matt561
chore: removed navigationOverride from mUSD conversion flows
995499d
@Matt561
feat: removed unused improt in TokenListItem
08a8d56
@Matt561 Matt561 force-pushed the feat/musd-691-clean-up-deprecated-quick-convert-code branch from 712603e to 08a8d56 Compare May 1, 2026 20:30
@Matt561 Matt561 marked this pull request as ready for review May 1, 2026 20:30
@Matt561 Matt561 requested review from a team as code owners May 1, 2026 20:30
cursor[bot]
cursor Bot reviewed May 1, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 08a8d56. Configure here.

Comment thread app/core/Analytics/MetaMetrics.events.ts
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeStake, SmokeConfirmations, SmokeMoney, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR removes the mUSD Quick Convert feature (screen, route, feature flags, analytics events, selectors, and navigation overrides). Key impacts:

  1. SmokeStake: The Earn lending flows (deposit/withdrawal) use mUSD conversion. The useMusdConversion hook changes affect how conversion navigation works. The lending deposit/withdrawal confirmation views are in the Earn route stack. Need to verify the remaining conversion flow (custom amount screen) still works correctly after removing the Quick Convert path.

  2. SmokeConfirmations: Required alongside SmokeStake as lending/staking flows involve transaction confirmations. The mUSD conversion flow ultimately leads to on-chain transactions.

  3. SmokeMoney: The MoneyConvertStablecoins component was updated (renamed ConvertTokenRow → MusdConversionAssetRow), and CashTokensFullView had navigation override logic removed. The Money hub stablecoin conversion flow is directly affected.

  4. SmokeWalletPlatform: The TokenListItem component was modified (removed isQuickConvertEnabled selector and MUSD_CONVERSION_NAVIGATION_OVERRIDE.QUICK_CONVERT), and Homepage test was updated. The token list is a core wallet platform component. The CashGetMusdEmptyState in Homepage sections was also modified.

The changes are a clean feature removal with no new functionality introduced. The risk is medium because multiple user-facing components were modified, and the navigation flow for mUSD conversion changed. No changes to core Engine, controllers, or critical infrastructure. The feature flag registry change removes two flags that were previously active in production.

Performance Test Selection:
The changes are a feature removal (Quick Convert screen/flow) with no new UI rendering, list components, or data loading patterns introduced. The modifications to TokenListItem are minor (removing a selector and conditional logic), not adding new rendering complexity. No performance-sensitive paths like app startup, account list rendering, or swap flows are affected.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Matt561 Matt561 added this pull request to the merge queue May 1, 2026
Merged via the queue into main with commit 484fa2b May 1, 2026
107 of 109 checks passed
@Matt561 Matt561 deleted the feat/musd-691-clean-up-deprecated-quick-convert-code branch May 1, 2026 21:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@cortisiko cortisiko cortisiko approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XL team-earn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Matt561 @cortisiko @Prithpal-Sooriya @gambinish