fix: money account withdraw should not be enabled in case there is no quote#29342
Conversation
…metamask-mobile into mmpay_account_override
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29342 +/- ##
==========================================
- Coverage 82.15% 81.95% -0.20%
==========================================
Files 5178 5186 +8
Lines 137450 138128 +678
Branches 31079 31317 +238
==========================================
+ Hits 112924 113207 +283
- Misses 16875 17230 +355
- Partials 7651 7691 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: The PR contains three changes:
Impact tracing:
Dependent tags per descriptions:
No performance impact expected from this alert logic change. Performance Test Selection: |
|



Description
It should not be possible to submit money account withdraw if there is no quote.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1230
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk: changes blocking alert logic used to disable submission in post-quote withdrawal flows, so edge-case gating could become too strict or too lenient if required-token/max-amount signals are wrong.
Overview
Prevents money account withdraw from being enabled when no quote is available in post-quote scenarios where
sourceAmountscan be empty (e.g., same-token/same-chain withdraws filtered out bycalculatePostQuoteSourceAmounts).useNoPayTokenQuotesAlertnow also triggers the blocking No quotes alert for post-quote flows when there’s a positive required-token input (orisMaxAmount), even ifsourceAmountsis empty, and the test suite adds coverage for these new edge cases.Reviewed by Cursor Bugbot for commit b609cd1. Bugbot is set up for automated code reviews on this repo. Configure here.