Description

When no viable quote existed for a Perps withdraw (e.g. $0.1 → ETH on Ethereum), the confirmation still showed a big transaction fee and an enabled Withdraw button, letting the user submit into a failing transaction.

useNoPayTokenQuotesAlert's isOptionalOnly check was matching the post-quote sourceAmount.targetTokenAddress (the destination token, e.g. native ETH 0x0…0) against a skipIfBalance required token on a different chain (Arbitrum native gas, also 0x0…0). That false match suppressed the NoPayTokenQuotes alert. isOptionalOnly is only meaningful for non-post-quote flows, so this PR bypasses it for post-quote. The existing CustomAmountInfo logic then hides the fee rows and shows the disabled "No quotes" button as designed.

Changelog

CHANGELOG entry: Fixed Perps withdraw showing a transaction fee and enabled button when no route was available; the rows now hide and the button shows "No quotes".

Related issues

Fixes: #29297

Manual testing steps

Feature: Perps withdraw handles missing quotes

  Scenario: no viable quote for the amount
    Given user is on the Perps withdraw confirmation
    When user enters "0.1" and selects "ETH on Ethereum"
    And user presses Done
    Then "Transaction fee" and "You'll receive" rows are not shown
    And the primary button shows "No quotes" and is disabled

  Scenario: viable quote exists (regression)
    Given user is on the Perps withdraw confirmation
    When user enters a viable amount and selects any receive token
    And user presses Done
    Then "Transaction fee" and "You'll receive" rows are shown
    And the primary button shows "Withdraw" and is enabled

Screenshots/Recordings

Before

After

$0.1

$0.5

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.