Skip to content

chore(rewards): no date in campaign tile for upcoming#29311

Merged
VGR-GIT merged 1 commit into
mainfrom
rwds-upcoming-campaigns-no-date-in-card
Apr 24, 2026
Merged

chore(rewards): no date in campaign tile for upcoming#29311
VGR-GIT merged 1 commit into
mainfrom
rwds-upcoming-campaigns-no-date-in-card

Conversation

@VGR-GIT

@VGR-GIT VGR-GIT commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Description

Don't show a date in the campaign card is the status is upcoming

Changelog

CHANGELOG entry: null


Note

Low Risk
Low risk UI-only change that conditionally hides existing text; main risk is small visual regression if other statuses were expected to show the date separator/label.

Overview
Upcoming reward campaigns no longer show a date line in the campaign tile. CampaignTile now conditionally renders the date separator and dateLabel only when campaignStatus !== 'upcoming'.

Tests were updated to assert that the campaign-tile-date-info element is not rendered for upcoming campaigns (while still present for active/complete).

Reviewed by Cursor Bugbot for commit c9a2d89. Bugbot is set up for automated code reviews on this repo. Configure here.

@VGR-GIT VGR-GIT requested a review from a team as a code owner April 24, 2026 09:12
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added team-rewards Rewards team INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains two files: a minor UI fix in CampaignTile.tsx (conditionally hiding the date label for 'upcoming' campaigns) and its corresponding unit test update. The change is a simple conditional render — wrapping the bullet and date Text components in a {campaignStatus !== 'upcoming' && (...)} guard. No E2E tests reference CampaignTile, Rewards campaigns, or OndoCampaign components. The Rewards/Campaigns feature is not covered by any of the available E2E test tags. The change has no impact on shared components (navigation, modals, confirmations, controllers, Engine), no performance implications, and no cross-cutting concerns. Running any E2E tag would be unnecessary overhead with zero validation benefit for these changes.

Performance Test Selection:
The change is a simple conditional render that reduces DOM nodes for upcoming campaigns. This has negligible performance impact and does not affect any performance-sensitive paths (account lists, onboarding, login, swaps, app launch, asset loading, predictions, or perps).

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@VGR-GIT VGR-GIT enabled auto-merge April 24, 2026 09:52
@VGR-GIT VGR-GIT added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit abe7112 Apr 24, 2026
88 checks passed
@VGR-GIT VGR-GIT deleted the rwds-upcoming-campaigns-no-date-in-card branch April 24, 2026 10:09
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-S team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants