Skip to content

fix: MUSD-696 fix money hub deeplink navigation cp-7.74.0#29288

Merged
Matt561 merged 7 commits into
mainfrom
fix/musd-696-fix-money-hub-deeplink-navigation
Apr 23, 2026
Merged

fix: MUSD-696 fix money hub deeplink navigation cp-7.74.0#29288
Matt561 merged 7 commits into
mainfrom
fix/musd-696-fix-money-hub-deeplink-navigation

Conversation

@Matt561

@Matt561 Matt561 commented Apr 23, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes invalid deeplink navigation for Money Hub feature.

Changelog

CHANGELOG entry: fixes invalid deeplink navigation for Money Hub feature.

Related issues

Fixes:

Manual testing steps

Feature: Money Hub deeplink navigation

  Scenario: user opens earn-musd deeplink after seeing the education screen
    Given user has previously seen the mUSD conversion education screen
    And user is geo-eligible for mUSD conversion
    And the Money Hub feature flag is enabled

    When user opens the earn-musd deeplink
    Then user is navigated to the Money Hub

  Scenario: user opens earn-musd deeplink when Money Hub is disabled
    Given user has previously seen the mUSD conversion education screen
    And user is geo-eligible for mUSD conversion
    And the Money Hub feature flag is disabled

    When user opens the earn-musd deeplink
    Then user is navigated to the Wallet home screen

  Scenario: user opens earn-musd deeplink when geo-ineligible
    Given user has previously seen the mUSD conversion education screen
    And user is geo-ineligible for mUSD conversion

    When user opens the earn-musd deeplink
    Then user is navigated to the Wallet home screen

  Scenario: user opens earn-musd deeplink before seeing the education screen
    Given user has not seen the mUSD conversion education screen

    When user opens the earn-musd deeplink
    Then user is navigated to the mUSD conversion education screen with the deeplink flag set

  Scenario: user dismisses the education screen via deeplink with Money Hub enabled
    Given user arrived at the mUSD conversion education screen via deeplink
    And user is geo-eligible for mUSD conversion
    And the Money Hub feature flag is enabled

    When user taps "Not Now"
    Then the education screen is popped from the navigation stack
    And user is navigated to the Money Hub

  Scenario: user dismisses the education screen in normal (non-deeplink) flow
    Given user arrived at the mUSD conversion education screen via normal navigation

    When user taps "Not Now"
    Then user is navigated back to the previous screen

Screenshots/Recordings

Before

After

Pre-merge author checklist

fixed_money_hub_incorrect_deeplink_navigation.mov

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes deeplink and education-screen navigation decisions for mUSD, including geo-eligibility gating and a new Money Hub redirect path; incorrect conditions could send users to the wrong screen or bypass intended compliance blocking.

Overview
Fixes earn-musd deeplink behavior by routing users who have already seen the mUSD education screen directly to Money Hub (Routes.WALLET.CASH_TOKENS_FULL_VIEW) when the Money Hub flag is enabled and the user is geo-eligible; otherwise it falls back to Routes.WALLET.HOME.

Updates the mUSD conversion education screen to support a new deeplink action navigate_money_hub (including analytics redirects_to), and changes the secondary "Not now" behavior to pop the screen and redirect to Money Hub only for deeplink + geo-eligible + flag-enabled cases.

Refactors geo-eligibility computation into a new memoized selector selectIsMusdConversionGeoEligible (with tests) and wires useMusdConversionEligibility to use it; several unrelated tests were updated to mock getDetectedGeolocation/selectMusdConversionBlockedCountries.

Reviewed by Cursor Bugbot for commit 78d390a. Bugbot is set up for automated code reviews on this repo. Configure here.

@Matt561 Matt561 requested review from a team as code owners April 23, 2026 18:47
@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]
cursor Bot reviewed Apr 23, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 69aefcf. Configure here.

Comment thread app/components/UI/Earn/Views/EarnMusdConversionEducationView/index.tsx
joaoloureirop
joaoloureirop previously approved these changes Apr 23, 2026
View reviewed changes
Cal-L
Cal-L previously approved these changes Apr 23, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Jwhiles
Jwhiles previously approved these changes Apr 23, 2026
View reviewed changes
@Matt561 Matt561 dismissed stale reviews from Jwhiles, Cal-L, and joaoloureirop via d0fbbe3 April 23, 2026 19:24
@Matt561 Matt561 requested a review from a team as a code owner April 23, 2026 19:24
gambinish
gambinish previously approved these changes Apr 23, 2026
View reviewed changes
Cal-L
Cal-L previously approved these changes Apr 23, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Matt561 Matt561 dismissed stale reviews from Cal-L and gambinish via 47d910e April 23, 2026 19:45
@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Apr 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@Matt561 Matt561 enabled auto-merge April 23, 2026 20:36
@Matt561 Matt561 added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 0b114db Apr 23, 2026
116 checks passed
@Matt561 Matt561 deleted the fix/musd-696-fix-money-hub-deeplink-navigation branch April 23, 2026 21:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@wachunei wachunei wachunei approved these changes

@shane-t shane-t shane-t approved these changes

@gambinish gambinish gambinish approved these changes

@joaoloureirop joaoloureirop joaoloureirop approved these changes

@Jwhiles Jwhiles Awaiting requested review from Jwhiles

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees

No one assigned

Labels

release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-L team-earn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Matt561 @wachunei @shane-t @Cal-L @Jwhiles @gambinish @joaoloureirop