Skip to content

fix: Use development profile for main dev environment#29286

Merged
Cal-L merged 4 commits into
mainfrom
fix/use-development-profile-main-dev
Apr 23, 2026
Merged

fix: Use development profile for main dev environment#29286
Cal-L merged 4 commits into
mainfrom
fix/use-development-profile-main-dev

Conversation

@Cal-L

@Cal-L Cal-L commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description

It was discovered that we're still using UAT signing configuration for main-dev builds, which is incorrect. It should be using a development profile. Since we have not yet set up a development profile in AWS, this PR temporarily routes main-dev to use github environments instead.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensys.slack.com/archives/C02U025CVU4/p1776699450350369

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it changes CI code-signing behavior and secret sources for main-dev iOS builds, which can break build/release outputs if misconfigured. Scope is limited to the main-dev workflow path and does not affect prod/rc signing via AWS.

Overview
Updates main-dev to stop using UAT AWS signing config and instead temporarily sign iOS builds using GitHub Environment secrets until dev signing is migrated to AWS.

Adds a build.yml step that, for ios + main-dev only, decodes a base64 .p12 and provisioning profile from secrets, creates/imports them into a temporary keychain, and installs the provisioning profile. builds.yml is adjusted to omit the main-dev AWS signing block and to include the new iOS signing secret mappings.

Reviewed by Cursor Bugbot for commit 083bee9. Bugbot is set up for automated code reviews on this repo. Configure here.

@Cal-L Cal-L requested a review from a team as a code owner April 23, 2026 18:28
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label Apr 23, 2026
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 23, 2026
weitingsun
weitingsun previously approved these changes Apr 23, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 23, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5243ef6. Configure here.

Comment thread .github/workflows/build.yml Outdated
tommasini
tommasini previously approved these changes Apr 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely CI/build infrastructure modifications:

  1. .github/workflows/build.yml: Adds a new step "Configure iOS signing from GitHub secrets" that only executes when matrix.platform == 'ios' AND inputs.build_name == 'main-dev'. This step handles iOS code signing using GitHub Environment secrets (certificate, provisioning profile, keychain setup) as a temporary bridge while signing is migrated to AWS.

  2. builds.yml: Updates the main-dev build configuration to comment out the signing: *signing_uat reference and expand the secrets block to include three iOS signing secrets (IOS_SIGNING_KEYSTORE, IOS_SIGNING_KEYSTORE_PASSWORD, IOS_SIGNING_PROFILE).

These changes are scoped entirely to the CI build pipeline for the main-dev iOS build variant. No application source code, test files, controllers, UI components, or user-facing functionality was modified. The changes do not affect app behavior, rendering, state management, or any user flows. Therefore, no E2E test tags or performance tests are required.

Performance Test Selection:
No performance-relevant changes. The modifications are limited to CI build pipeline configuration for iOS code signing. No UI components, data loading, state management, or app initialization code was changed.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@Cal-L Cal-L added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 5a8bb05 Apr 23, 2026
102 of 113 checks passed
@Cal-L Cal-L deleted the fix/use-development-profile-main-dev branch April 23, 2026 22:29
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 23, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-S team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants