Skip to content

chore: update uuid to v14.0.0#29224

Merged
tommasini merged 5 commits into
mainfrom
chore/update-uuid-dep
May 19, 2026
Merged

chore: update uuid to v14.0.0#29224
tommasini merged 5 commits into
mainfrom
chore/update-uuid-dep

Conversation

@joaoloureirop

@joaoloureirop joaoloureirop commented Apr 22, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-557

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Major-version bump of uuid can change module format/typing and affect any runtime UUID generation paths, especially in React Native/Jest transforms. The code changes are small but dependency behavior changes could surface at build/test time or in places relying on uuid options.

Overview
Upgrades uuid from ^8.3.2 to ^14.0.0 (and updates yarn.lock accordingly), removing the now-unneeded npm audit ignore entry for the prior uuid advisory.

Adjusts test infrastructure for the new uuid package shape: adds uuid to Jest’s transformIgnorePatterns allowlist, updates analyticsId.test.ts’s v4 mock typing, and tweaks accountsControllerTestUtils.ts to cast the v4({ random }) input to Uint8Array for the updated type expectations.

Reviewed by Cursor Bugbot for commit 608d200. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label Apr 22, 2026
@socket-security

socket-security Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​uuid@​14.0.010010010092100

View full report

@socket-security

socket-security Bot commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@joaoloureirop joaoloureirop force-pushed the chore/update-uuid-dep branch from edd2f01 to 3650d03 Compare May 19, 2026 14:27
@tommasini tommasini marked this pull request as ready for review May 19, 2026 16:23
cursor[bot]
cursor Bot reviewed May 19, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ceef559. Configure here.

Comment thread package.json
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR upgrades the uuid package from v8.3.2 to v14.0.0 and makes the necessary compatibility fixes:

  1. package.json: Major version bump uuid v8 → v14. The core API (v4, v1) remains functionally identical — UUIDs are still generated the same way.

  2. jest.config.js: Adds uuid to Jest's transformIgnorePatterns exclusion so Jest will transpile the uuid package (uuid v14 uses ESM modules, requiring Babel transformation in Jest's Node environment).

  3. accountsControllerTestUtils.ts: TypeScript type cast fix (as unknown as Uint8Array) for uuid v14's stricter typing on the random option parameter.

  4. analyticsId.test.ts: Updates mock type from jest.MockedFunction<typeof v4> to jest.Mock<string> for uuid v14 compatibility.

  5. .yarnrc.yml: Removes the security advisory suppression for uuid (the vulnerability is now resolved by upgrading to v14).

  6. yarn.lock: Lock file update.

Why no E2E tests are needed:

  • The changes are purely a dependency upgrade with TypeScript/Jest compatibility fixes
  • UUID generation behavior (v4, v1) is functionally identical between v8 and v14
  • No user-facing UI, business logic, or E2E test infrastructure was changed
  • The fixes are in test utilities and Jest configuration, not in production code paths that E2E tests exercise
  • The uuid package is used for ID generation (analytics IDs, request IDs, etc.) — the format and behavior remain the same

Why no performance tests are needed:

  • UUID generation is a trivial operation with negligible performance impact
  • No rendering, state management, or data loading code was changed

Performance Test Selection:
UUID generation is a trivial operation with negligible performance impact. No rendering, state management, data loading, or critical user flow code was changed — only the uuid dependency version and Jest/TypeScript compatibility fixes.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes May 19, 2026
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tommasini tommasini added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 8f0d058 May 19, 2026
147 of 158 checks passed
@tommasini tommasini deleted the chore/update-uuid-dep branch May 19, 2026 22:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaoloureirop @Cal-L @tommasini