test: MMQA -1712-[Mobile] Update the mobile e2e tests to account for home page redesign enabled#29100
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cortisiko
left a comment
There was a problem hiding this comment.
@LeVinhGithub the PR looks good, but there are failing tests. can you have a look when you get a chance ?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 704e112. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Changed files breakdown:
Tag selection rationale:
No performance-impacting app code was changed - all changes are test infrastructure only. Performance Test Selection: |
|
Description
Multiple E2E tests were disabling the
homepageRedesignV1andhomepageSectionsV1feature flags to work around the redesigned homepage UI. This caused a test/production parity gap — tests were running against the old homepage while production users see the new redesigned version.This PR removes all
homepageRedesignV1: false/homepageSectionsV1: falsemock overrides and adapts the affected tests to work with the new redesigned homepage. The key change is that network switching now requires navigating toTokensFullViewfirst (via the Tokens section header) since the network filter control bar only exists there, not on the homepage itself.Changes
homepageRedesignV1andhomepageSectionsV1flag overrides from 7 test files and 1 mock helpernavigateToTokensFullView(),navigateBackFromTokensFullView(), andopenNetworkManagerFromHomepage()methods to theNetworkManagerpage objectper-dapp-selected-network,batch-transaction,stake-action-smoke,network-manager, andnetwork-manager2specs to go throughTokensFullViewtapSelectAllPopularNetworks()steps inincoming-transactionstests to handle single-network fixtureswithTokens()for the custom network filter testChangelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1712
Manual testing steps
Scenario 1: Network manager tests pass with redesigned homepage
Scenario 2: Incoming transactions test with single-network fixture
Scenario 3: Dapp per-network transaction with redesigned homepage
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk since changes are limited to E2E test code and mocks, but it may cause CI failures if the redesigned homepage navigation or selectors change again.
Overview
Updates multiple mobile E2E smoke specs to run against the redesigned homepage defaults by removing overrides that forced
homepageRedesignV1/homepageSectionsV1off.Introduces new
NetworkManagerpage-object helpers to reach the network filter viaTokensFullView, and rewires network-switching steps across confirmation, network-manager, stake, and incoming-transactions tests (including selecting all popular networks where single-network fixtures would hide activity).Adjusts fixtures/mocks to match the new flows (e.g.,
withPopularNetworks()usage, removing explicitwithNetworkEnabledMapin the mUSD fixture, and updating the mUSD happy-path assertion to the Cash section container).Reviewed by Cursor Bugbot for commit 61dc1b7. Bugbot is set up for automated code reviews on this repo. Configure here.