Skip to content

fix: tempo and eip 7702 txs activity remove nonce row cp-7.74.0#29066

Merged
maxime-oe merged 1 commit into
mainfrom
fix/tempo-handle-missing-nonce
Apr 24, 2026
Merged

fix: tempo and eip 7702 txs activity remove nonce row cp-7.74.0#29066
maxime-oe merged 1 commit into
mainfrom
fix/tempo-handle-missing-nonce

Conversation

@maxime-oe

@maxime-oe maxime-oe commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry: remove the nonce line from tx activity popin when nonce is missing.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NEB-966?atlOrigin=eyJpIjoiZTNjN2MyZGZiYmNhNDNjYTllNWUxNGFmNmE1YmMwYmMiLCJwIjoiaiJ9

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
  1. You can perform any tx from Mobile on Tempo (as long as you don't use a Hardware Wallet) to generate an activity in the Activity tab.
  2. Click on the successful tx on Activity tab
  3. Observe absence of any nonce line (vs. empty "nonce" field before).

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only conditional rendering change with a small accompanying test update; no changes to transaction processing or network logic.

Overview
The transaction details modal now omits the “Nonce” section entirely when txParams.nonce is not provided, instead of rendering an empty row.

Tests were updated to cover both cases (nonce present vs. missing) to ensure the UI consistently hides/shows the nonce row as expected.

Reviewed by Cursor Bugbot for commit e4e8b70. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-networks Networks team label Apr 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@maxime-oe maxime-oe marked this pull request as ready for review April 20, 2026 17:08
@maxime-oe maxime-oe requested a review from a team as a code owner April 20, 2026 17:08
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e4e8b70. Configure here.

@nikolastoimenovski-consensys

Copy link
Copy Markdown

Tested with and without HW, works as expected on Send, Swap, Bridge (using dapp), Tempo batch trx using test dapp. Feedback:

  • without HW, the "nonce" field is not shown
  • with HW, the "nonce" field is shown and it is populated
    Adding the "qa passed" label.

@nikolastoimenovski-consensys nikolastoimenovski-consensys added the QA Passed QA testing has been completed and passed label Apr 24, 2026
@maxime-oe maxime-oe changed the title fix: tempo and eip 7702 txs activity remove nonce row fix: tempo and eip 7702 txs activity remove nonce row cp-7.74.0 Apr 24, 2026
@maxime-oe maxime-oe added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit c5532e5 Apr 24, 2026
155 of 157 checks passed
@maxime-oe maxime-oe deleted the fix/tempo-handle-missing-nonce branch April 24, 2026 11:31
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.76.0 Issue or pull request that will be included in release 7.76.0 label Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.76.0 Issue or pull request that will be included in release 7.76.0 size-S team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants