fix: tempo and eip 7702 txs activity remove nonce row cp-7.74.0#29066
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4e8b70. Configure here.
|
Tested with and without HW, works as expected on Send, Swap, Bridge (using dapp), Tempo batch trx using test dapp. Feedback:
|




Description
Changelog
CHANGELOG entry: remove the nonce line from tx activity popin when nonce is missing.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NEB-966?atlOrigin=eyJpIjoiZTNjN2MyZGZiYmNhNDNjYTllNWUxNGFmNmE1YmMwYmMiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only conditional rendering change with a small accompanying test update; no changes to transaction processing or network logic.
Overview
The transaction details modal now omits the “Nonce” section entirely when
txParams.nonceis not provided, instead of rendering an empty row.Tests were updated to cover both cases (nonce present vs. missing) to ensure the UI consistently hides/shows the nonce row as expected.
Reviewed by Cursor Bugbot for commit e4e8b70. Bugbot is set up for automated code reviews on this repo. Configure here.