Skip to content

chore(runway): cherry-pick fix: update chart container layout cp-7.74.0#29029

Merged
chloeYue merged 1 commit into
release/7.74.00from
runway-cherry-pick-7.74.0-1776678301
Apr 20, 2026
Merged

chore(runway): cherry-pick fix: update chart container layout cp-7.74.0#29029
chloeYue merged 1 commit into
release/7.74.00from
runway-cherry-pick-7.74.0-1776678301

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Description

Improves the TradingView Advanced Chart layout on the token details
screen so that price scale tick labels are better positioned and less
likely to appear clipped on certain tokens.

Changelog

CHANGELOG entry: Improved advanced chart layout to reduce price scale
label clipping on the token details screen

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
UI/layout-only chart rendering changes with minimal logic impact; main
risk is visual regressions in empty/loading chart states across devices.

Overview
Improves token detail chart layout to reduce clipped/awkward
price-scale labels, primarily by letting the TradingView WebView surface
fully fill its container and tweaking pane top/bottom margins.

Simplifies the legacy PriceChart empty-state behavior by not
rendering placeholder chart/gradient when data is insufficient
, and
disabling pan handlers unless real chart data is present; also removes
unused placeholderData and trims related SVG imports. Separately
removes overflow-hidden from the advanced price chart wrapper so chart
chrome/labels aren’t clipped.

Reviewed by Cursor Bugbot for commit
7307d7d. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[4345902](https://github.com/MetaMask/metamask-mobile/commit/43459020ed4b239b09515f196bc94b4c41b29109)

….0 (#29023)

## **Description**

Improves the TradingView Advanced Chart layout on the token details
screen so that price scale tick labels are better positioned and less
likely to appear clipped on certain tokens.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Improved advanced chart layout to reduce price scale
label clipping on the token details screen

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> UI/layout-only chart rendering changes with minimal logic impact; main
risk is visual regressions in empty/loading chart states across devices.
> 
> **Overview**
> Improves token detail chart layout to reduce clipped/awkward
price-scale labels, primarily by letting the TradingView WebView surface
fully fill its container and tweaking pane top/bottom margins.
> 
> Simplifies the legacy `PriceChart` empty-state behavior by **not
rendering placeholder chart/gradient when data is insufficient**, and
disabling pan handlers unless real chart data is present; also removes
unused `placeholderData` and trims related SVG imports. Separately
removes `overflow-hidden` from the advanced price chart wrapper so chart
chrome/labels aren’t clipped.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
7307d7d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner April 20, 2026 09:45
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 20, 2026
@github-actions github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Apr 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue enabled auto-merge (squash) April 20, 2026 11:06
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@chloeYue chloeYue merged commit 9746dc2 into release/7.74.00 Apr 20, 2026
111 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.74.0-1776678301 branch April 20, 2026 12:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-high Extensive testing required · High bug introduction risk size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants